-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for 21 different rubocop cop violations #831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
changed the title
WIP: More Rubocop
Fixes for 21 different rubocop cop violations.
Jan 31, 2018
alexjfisher
changed the title
Fixes for 21 different rubocop cop violations.
Fixes for 21 different rubocop cop violations
Jan 31, 2018
alexjfisher
force-pushed
the
migration2
branch
2 times, most recently
from
January 31, 2018 21:35
80b5edf
to
0c8285f
Compare
alexjfisher
force-pushed
the
migration2
branch
from
January 31, 2018 22:17
0c8285f
to
b9f095c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all rubocop autofixes but done as individual commits and reviewed.
With each fix, care is taken to not introduce (or reintroduce) other violations.
This PR takes the total violation count down from 2256 to 1375.
The last commit was the result of running.
This PR is hopefully a good compromise between a separate PR per fix and a PR too big for review. There are still more fixes (auto fixable and those that can't be) needed.