Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 21 different rubocop cop violations #831

Merged
merged 21 commits into from
Jan 31, 2018

Conversation

alexjfisher
Copy link
Member

@alexjfisher alexjfisher commented Jan 31, 2018

These are all rubocop autofixes but done as individual commits and reviewed.
With each fix, care is taken to not introduce (or reintroduce) other violations.

This PR takes the total violation count down from 2256 to 1375.
The last commit was the result of running.

rubocop -D -S -E --only Layout/SpaceAroundBlockParameters,Layout/EmptyLinesAroundBlockBody,Style/StringLiterals,Layout/SpaceAroundOperators,Style/TrailingCommaInLiteral,Layout/SpaceAfterComma,Layout/LeadingCommentSpace,Layout/CaseIndentation,Style/RedundantReturn,Style/CollectionMethods,Style/RedundantParentheses,Style/AndOr,Layout/AlignHash,Style/BlockDelimiters,Style/NegatedIf,Style/MultilineIfThen,Lint/UnusedBlockArgument,Layout/ExtraSpacing,Style/ParenthesesAroundCondition,Style/IfUnlessModifier,RSpec/ExampleWording,Style/ParenthesesAroundCondition,Layout/EmptyLines,Style/MethodCallWithoutArgsParentheses,Layout/SpaceInsideBlockBraces,Layout/SpaceInsideHashLiteralBraces -a

This PR is hopefully a good compromise between a separate PR per fix and a PR too big for review. There are still more fixes (auto fixable and those that can't be) needed.

@alexjfisher alexjfisher changed the title WIP: More Rubocop Fixes for 21 different rubocop cop violations. Jan 31, 2018
@alexjfisher alexjfisher changed the title Fixes for 21 different rubocop cop violations. Fixes for 21 different rubocop cop violations Jan 31, 2018
@alexjfisher alexjfisher force-pushed the migration2 branch 2 times, most recently from 80b5edf to 0c8285f Compare January 31, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants