From 14849dd578ddf870dcda2bcc0bb197050cf1b136 Mon Sep 17 00:00:00 2001
From: Andreas Unterkircher <unki@netshadow.net>
Date: Sat, 29 Feb 2020 09:55:02 +0100
Subject: [PATCH] have a $service_name parameter for all prometheus-exporters

---
 data/defaults.yaml                  | 14 ++++++++++++++
 manifests/beanstalkd_exporter.pp    |  7 +++++--
 manifests/bird_exporter.pp          |  4 ++--
 manifests/blackbox_exporter.pp      |  4 ++--
 manifests/collectd_exporter.pp      |  7 +++++--
 manifests/consul_exporter.pp        |  7 +++++--
 manifests/elasticsearch_exporter.pp |  5 +++--
 manifests/graphite_exporter.pp      |  7 +++++--
 manifests/haproxy_exporter.pp       |  4 ++--
 manifests/mesos_exporter.pp         |  7 +++++--
 manifests/mongodb_exporter.pp       |  7 +++++--
 manifests/mysqld_exporter.pp        |  7 +++++--
 manifests/nginx_vts_exporter.pp     |  7 +++++--
 manifests/node_exporter.pp          |  4 ++--
 manifests/process_exporter.pp       |  7 +++++--
 manifests/rabbitmq_exporter.pp      |  7 +++++--
 manifests/redis_exporter.pp         |  2 +-
 manifests/snmp_exporter.pp          |  7 +++++--
 manifests/statsd_exporter.pp        |  7 +++++--
 manifests/varnish_exporter.pp       |  7 +++++--
 20 files changed, 91 insertions(+), 37 deletions(-)

diff --git a/data/defaults.yaml b/data/defaults.yaml
index 2214959f9..fcecb613e 100644
--- a/data/defaults.yaml
+++ b/data/defaults.yaml
@@ -77,6 +77,7 @@ prometheus::consul_exporter::group: 'consul-exporter'
 prometheus::consul_exporter::log_level: 'info'
 prometheus::consul_exporter::package_ensure: 'latest'
 prometheus::consul_exporter::package_name: 'consul_exporter'
+prometheus::consul_exporter::service_name: 'consul_exporter'
 prometheus::consul_exporter::user: 'consul-exporter'
 prometheus::consul_exporter::version: '0.5.0'
 prometheus::consul_exporter::web_listen_address: ':9107'
@@ -91,6 +92,7 @@ prometheus::elasticsearch_exporter::extra_groups: []
 prometheus::elasticsearch_exporter::group: 'elasticsearch-exporter'
 prometheus::elasticsearch_exporter::package_ensure: 'latest'
 prometheus::elasticsearch_exporter::package_name: 'elasticsearch_exporter'
+prometheus::elasticsearch_exporter::service_name: 'elasticsearch_exporter'
 prometheus::elasticsearch_exporter::user: 'elasticsearch-exporter'
 prometheus::elasticsearch_exporter::version: '1.1.0rc1'
 prometheus::elasticsearch_exporter::use_kingpin: true
@@ -112,6 +114,7 @@ prometheus::mesos_exporter::group: 'mesos-exporter'
 prometheus::mesos_exporter::user: 'mesos-exporter'
 prometheus::mesos_exporter::package_ensure: 'latest'
 prometheus::mesos_exporter::package_name: 'mesos_exporter'
+prometheus::mesos_exporter::service_name: 'mesos_exporter'
 prometheus::mesos_exporter::version: '1.1.2'
 prometheus::haproxy_exporter::cnf_scrape_uri: 'http://localhost:1234/haproxy?stats;csv'
 prometheus::haproxy_exporter::download_extension: 'tar.gz'
@@ -130,6 +133,7 @@ prometheus::nginx_vts_exporter::extra_groups: []
 prometheus::nginx_vts_exporter::group: 'nginx-vts-exporter'
 prometheus::nginx_vts_exporter::package_ensure: 'latest'
 prometheus::nginx_vts_exporter::package_name: 'nginx-vts-exporter'
+prometheus::nginx_vts_exporter::service_name: 'nginx-vts-exporter'
 prometheus::nginx_vts_exporter::user: 'nginx-vts-exporter'
 prometheus::nginx_vts_exporter::version: '0.10.3'
 prometheus::process_exporter::download_extension: 'tar.gz'
@@ -138,6 +142,7 @@ prometheus::process_exporter::extra_groups: []
 prometheus::process_exporter::group: 'process-exporter'
 prometheus::process_exporter::package_ensure: 'latest'
 prometheus::process_exporter::package_name: 'process-exporter'
+prometheus::process_exporter::service_name: 'process-exporter'
 prometheus::process_exporter::user: 'process-exporter'
 prometheus::process_exporter::version: '0.5.0'
 prometheus::process_exporter::config_path: '/etc/process-exporter.yaml'
@@ -155,6 +160,7 @@ prometheus::rabbitmq_exporter::extra_groups: []
 prometheus::rabbitmq_exporter::group: 'rabbitmq-exporter'
 prometheus::rabbitmq_exporter::package_ensure: 'latest'
 prometheus::rabbitmq_exporter::package_name: 'rabbitmq_exporter'
+prometheus::rabbitmq_exporter::service_name: 'rabbitmq_exporter'
 prometheus::rabbitmq_exporter::user: 'rabbitmq-exporter'
 prometheus::rabbitmq_exporter::version: '0.25.2'
 prometheus::rabbitmq_exporter::rabbit_url: 'http://localhost:15672'
@@ -174,6 +180,7 @@ prometheus::mysqld_exporter::extra_groups: []
 prometheus::mysqld_exporter::group: 'mysqld-exporter'
 prometheus::mysqld_exporter::package_ensure: 'latest'
 prometheus::mysqld_exporter::package_name: 'mysqld_exporter'
+prometheus::mysqld_exporter::service_name: 'mysqld_exporter'
 prometheus::mysqld_exporter::user: 'mysqld-exporter'
 prometheus::mysqld_exporter::version: '0.12.0'
 prometheus::mongodb_exporter::cnf_uri: 'mongodb://localhost:27017'
@@ -183,6 +190,7 @@ prometheus::mongodb_exporter::extra_groups: []
 prometheus::mongodb_exporter::group: 'mongodb-exporter'
 prometheus::mongodb_exporter::package_ensure: 'latest'
 prometheus::mongodb_exporter::package_name: 'mongodb_exporter'
+prometheus::mongodb_exporter::service_name: 'mongodb_exporter'
 prometheus::mongodb_exporter::user: 'mongodb-exporter'
 prometheus::mongodb_exporter::version: '0.3.1'
 prometheus::mongodb_exporter::use_kingpin: false
@@ -202,6 +210,7 @@ prometheus::beanstalkd_exporter::extra_groups: []
 prometheus::beanstalkd_exporter::group: 'beanstalkd-exporter'
 prometheus::beanstalkd_exporter::package_ensure: 'latest'
 prometheus::beanstalkd_exporter::package_name: 'beanstalkd_exporter'
+prometheus::beanstalkd_exporter::service_name: 'beanstalkd_exporter'
 prometheus::beanstalkd_exporter::user: 'beanstalkd-exporter'
 prometheus::beanstalkd_exporter::version: '1.0.0'
 prometheus::beanstalkd_exporter::mapping_config: '/etc/beanstalkd-exporter-mapping.conf'
@@ -229,6 +238,7 @@ prometheus::snmp_exporter::extra_groups: []
 prometheus::snmp_exporter::group: 'snmp-exporter'
 prometheus::snmp_exporter::package_ensure: 'latest'
 prometheus::snmp_exporter::package_name: 'snmp_exporter'
+prometheus::snmp_exporter::service_name: 'snmp_exporter'
 prometheus::snmp_exporter::user: 'snmp-exporter'
 prometheus::snmp_exporter::version: '0.15.0'
 prometheus::statsd_exporter::download_extension: 'tar.gz'
@@ -239,6 +249,7 @@ prometheus::statsd_exporter::mapping_config_path: '/etc/statsd-exporter-mapping.
 prometheus::statsd_exporter::mappings: []
 prometheus::statsd_exporter::package_ensure: 'latest'
 prometheus::statsd_exporter::package_name: 'statsd_exporter'
+prometheus::statsd_exporter::service_name: 'statsd_exporter'
 prometheus::statsd_exporter::user: 'statsd-exporter'
 prometheus::statsd_exporter::version: '0.12.1'
 prometheus::storage_retention: '360h' # 15d; "d" suffix is only supported with prom >= 2.*
@@ -279,6 +290,7 @@ prometheus::varnish_exporter::extra_groups: []
 prometheus::varnish_exporter::group: 'varnish'
 prometheus::varnish_exporter::package_ensure: 'latest'
 prometheus::varnish_exporter::package_name: 'prometheus_varnish_exporter'
+prometheus::varnish_exporter::service_name: 'prometheus_varnish_exporter'
 prometheus::varnish_exporter::user: 'varnish_exporter'
 prometheus::varnish_exporter::version: '1.5'
 prometheus::graphite_exporter::download_extension: 'tar.gz'
@@ -286,6 +298,7 @@ prometheus::graphite_exporter::download_url_base: 'https://github.com/prometheus
 prometheus::graphite_exporter::group: 'graphite-exporter'
 prometheus::graphite_exporter::package_ensure: 'latest'
 prometheus::graphite_exporter::package_name: 'graphite_exporter'
+prometheus::graphite_exporter::service_name: 'graphite_exporter'
 prometheus::graphite_exporter::user: 'graphite-exporter'
 prometheus::graphite_exporter::version: '0.2.0'
 prometheus::graphite_exporter::options: ''
@@ -294,6 +307,7 @@ prometheus::collectd_exporter::download_url_base: 'https://github.com/prometheus
 prometheus::collectd_exporter::group: 'collectd-exporter'
 prometheus::collectd_exporter::package_ensure: 'latest'
 prometheus::collectd_exporter::package_name: 'collectd_exporter'
+prometheus::collectd_exporter::service_name: 'collectd_exporter'
 prometheus::collectd_exporter::user: 'collectd-exporter'
 prometheus::collectd_exporter::version: '0.4.0'
 prometheus::collectd_exporter::options: ''
diff --git a/manifests/beanstalkd_exporter.pp b/manifests/beanstalkd_exporter.pp
index ab5bd4055..e4d3049d7 100644
--- a/manifests/beanstalkd_exporter.pp
+++ b/manifests/beanstalkd_exporter.pp
@@ -47,6 +47,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the beanstalkd exporter service (default 'beanstalkd_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -57,7 +59,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   String $config,
@@ -88,7 +91,7 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['beanstalkd_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/bird_exporter.pp b/manifests/bird_exporter.pp
index 76a28425a..a8c873909 100644
--- a/manifests/bird_exporter.pp
+++ b/manifests/bird_exporter.pp
@@ -58,7 +58,7 @@
   Array[String] $extra_groups             = ['bird'],
   String $group                           = 'bird-exporter',
   String $package_ensure                  = 'installed',
-  String $package_name                    = 'bird_exporter',
+  String[1] $package_name                 = 'bird_exporter',
   String $user                            = 'bird-exporter',
   String $version                         = '1.2.4',
   Boolean $purge_config_dir               = true,
@@ -90,7 +90,7 @@
     default => undef,
   }
 
-  prometheus::daemon { $service_name :
+  prometheus::daemon { $service_name:
     install_method     => $install_method,
     version            => $version,
     download_extension => $download_extension,
diff --git a/manifests/blackbox_exporter.pp b/manifests/blackbox_exporter.pp
index 6ae00e0d0..fbad37892 100644
--- a/manifests/blackbox_exporter.pp
+++ b/manifests/blackbox_exporter.pp
@@ -67,7 +67,7 @@
   Array[String] $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
   String $user,
   String $version,
   Boolean $restart_on_change              = true,
@@ -117,7 +117,7 @@
   }
 
 
-  prometheus::daemon { $service_name :
+  prometheus::daemon { $service_name:
     install_method     => $install_method,
     version            => $version,
     download_extension => $download_extension,
diff --git a/manifests/collectd_exporter.pp b/manifests/collectd_exporter.pp
index dbb65ecc9..9b45cd689 100644
--- a/manifests/collectd_exporter.pp
+++ b/manifests/collectd_exporter.pp
@@ -37,6 +37,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the collectd exporter service (default 'collectd_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -47,6 +49,7 @@
   String[1] $group,
   String[1] $package_ensure,
   String[1] $package_name,
+  String[1] $service_name,
   String[1] $user,
   String[1] $version,
   String $options,
@@ -72,11 +75,11 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['collectd_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
-  prometheus::daemon { 'collectd_exporter':
+  prometheus::daemon { $service_name:
     install_method     => $install_method,
     version            => $version,
     download_extension => $download_extension,
diff --git a/manifests/consul_exporter.pp b/manifests/consul_exporter.pp
index 71f3307be..799072382 100644
--- a/manifests/consul_exporter.pp
+++ b/manifests/consul_exporter.pp
@@ -45,6 +45,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the consul exporter service (default 'consul_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -62,7 +64,8 @@
   String $group,
   String $log_level,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   String $web_listen_address,
@@ -105,7 +108,7 @@
   }
 
   $notify_service = $restart_on_change ? {
-    true    => Service['consul_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/elasticsearch_exporter.pp b/manifests/elasticsearch_exporter.pp
index fc71e001c..e0aee4f5d 100644
--- a/manifests/elasticsearch_exporter.pp
+++ b/manifests/elasticsearch_exporter.pp
@@ -59,7 +59,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Boolean $use_kingpin,
@@ -87,7 +88,7 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['elasticsearch_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/graphite_exporter.pp b/manifests/graphite_exporter.pp
index 2a50e2a59..5e38bed1f 100644
--- a/manifests/graphite_exporter.pp
+++ b/manifests/graphite_exporter.pp
@@ -37,6 +37,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the graphite exporter service (default 'graphite_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -46,7 +48,8 @@
   String $download_url_base,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   String $options,
@@ -72,7 +75,7 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['graphite_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/haproxy_exporter.pp b/manifests/haproxy_exporter.pp
index d0f4134d0..793ab2d77 100644
--- a/manifests/haproxy_exporter.pp
+++ b/manifests/haproxy_exporter.pp
@@ -53,10 +53,10 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
-  String[1] $service_name,
+  String[1] $package_name,
   String $user,
   String $version,
+  String[1] $service_name,
   Prometheus::Uri $download_url_base,
   Boolean $purge_config_dir               = true,
   Boolean $restart_on_change              = true,
diff --git a/manifests/mesos_exporter.pp b/manifests/mesos_exporter.pp
index 80a7ae822..b0f6da22a 100644
--- a/manifests/mesos_exporter.pp
+++ b/manifests/mesos_exporter.pp
@@ -43,6 +43,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the mesos exporter service (default 'mesos_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -55,7 +57,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Boolean $purge_config_dir               = true,
@@ -80,7 +83,7 @@
 
   $real_download_url    = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
   $notify_service = $restart_on_change ? {
-    true    => Service['mesos_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/mongodb_exporter.pp b/manifests/mongodb_exporter.pp
index cd24e3344..154782886 100644
--- a/manifests/mongodb_exporter.pp
+++ b/manifests/mongodb_exporter.pp
@@ -41,6 +41,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the mongodb exporter service (default 'mongodb_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -56,7 +58,8 @@
   Array  $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Boolean $use_kingpin,
@@ -84,7 +87,7 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['mongodb_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/mysqld_exporter.pp b/manifests/mysqld_exporter.pp
index f76d27c44..54b45d814 100644
--- a/manifests/mysqld_exporter.pp
+++ b/manifests/mysqld_exporter.pp
@@ -54,6 +54,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the mysqld exporter service (default 'mysqld_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -64,7 +66,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Stdlib::Absolutepath $cnf_config_path           = '/etc/.my.cnf',
@@ -97,7 +100,7 @@
   #Please provide the download_url for versions < 0.9.0
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
   $notify_service = $restart_on_change ? {
-    true    => Service['mysqld_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/nginx_vts_exporter.pp b/manifests/nginx_vts_exporter.pp
index d923a486f..36a821c20 100644
--- a/manifests/nginx_vts_exporter.pp
+++ b/manifests/nginx_vts_exporter.pp
@@ -41,6 +41,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the nginx-vts exporter service (default 'nginx-vts-exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -52,7 +54,8 @@
   Array            $extra_groups,
   String           $group,
   String           $package_ensure,
-  String           $package_name,
+  String[1]        $package_name,
+  String[1]        $service_name,
   String           $user,
   String           $version,
   Boolean          $purge_config_dir  = true,
@@ -77,7 +80,7 @@
 
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
   $notify_service = $restart_on_change ? {
-    true    => Service['nginx-vts-exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/node_exporter.pp b/manifests/node_exporter.pp
index c67c08918..6190b06ea 100644
--- a/manifests/node_exporter.pp
+++ b/manifests/node_exporter.pp
@@ -60,7 +60,7 @@
   Array[String] $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
   String $user,
   String $version,
   Boolean $purge_config_dir               = true,
@@ -118,7 +118,7 @@
       join($cmd_collectors_enable, ' '),
       join($cmd_collectors_disable, ' ') ], ' ')
 
-  prometheus::daemon { $service_name :
+  prometheus::daemon { $service_name:
     install_method     => $install_method,
     version            => $version,
     download_extension => $download_extension,
diff --git a/manifests/process_exporter.pp b/manifests/process_exporter.pp
index 15f8be117..393288a11 100644
--- a/manifests/process_exporter.pp
+++ b/manifests/process_exporter.pp
@@ -39,6 +39,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the process exporter service (default 'process-exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -74,7 +76,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Stdlib::Absolutepath $config_path,
@@ -104,7 +107,7 @@
   $filename = "${package_name}-${version}.${os}-${arch}.${download_extension}"
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${filename}")
   $notify_service = $restart_on_change ? {
-    true    => Service['process-exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/rabbitmq_exporter.pp b/manifests/rabbitmq_exporter.pp
index c6682f790..ab6840db3 100644
--- a/manifests/rabbitmq_exporter.pp
+++ b/manifests/rabbitmq_exporter.pp
@@ -39,6 +39,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the rabbitmq exporter service (default 'rabbitmq_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -67,7 +69,8 @@
   Array[String] $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $download_extension,
   String $user,
   String $version,
@@ -101,7 +104,7 @@
 
   $real_download_url    = pick($download_url, "${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
   $notify_service = $restart_on_change ? {
-    true    => Service['rabbitmq_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/redis_exporter.pp b/manifests/redis_exporter.pp
index 7e8667dac..200f79be4 100644
--- a/manifests/redis_exporter.pp
+++ b/manifests/redis_exporter.pp
@@ -58,7 +58,7 @@
   Array[String] $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
   String $user,
   String $version,
   Boolean $purge_config_dir               = true,
diff --git a/manifests/snmp_exporter.pp b/manifests/snmp_exporter.pp
index ad68c7f71..25e532f25 100644
--- a/manifests/snmp_exporter.pp
+++ b/manifests/snmp_exporter.pp
@@ -45,6 +45,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the snmp exporter service (default 'snmp_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -57,7 +59,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Boolean $purge_config_dir               = true,
@@ -84,7 +87,7 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['snmp_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/statsd_exporter.pp b/manifests/statsd_exporter.pp
index 79931c7e0..22ef98c6b 100644
--- a/manifests/statsd_exporter.pp
+++ b/manifests/statsd_exporter.pp
@@ -41,6 +41,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the statsd exporter service (default 'statsd_exporter')
 # @param mappings
 #  The hiera array for mappings:
 #    - map: 'test.dispatcher.*.*.*'
@@ -59,7 +61,8 @@
   String $group,
   Stdlib::Absolutepath $mapping_config_path,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   Array[Hash] $mappings,
   String $user,
   String $version,
@@ -92,7 +95,7 @@
   $real_download_url = pick($download_url,"${download_url_base}/download/v${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
 
   $notify_service = $restart_on_change ? {
-    true    => Service['statsd_exporter'],
+    true    => Service[$service_name],
     default => undef,
   }
 
diff --git a/manifests/varnish_exporter.pp b/manifests/varnish_exporter.pp
index bae04274e..280fb04c2 100644
--- a/manifests/varnish_exporter.pp
+++ b/manifests/varnish_exporter.pp
@@ -39,6 +39,8 @@
 #  Whether to enable the service from puppet (default true)
 # @param service_ensure
 #  State ensured for the service (default 'running')
+# @param service_name
+#  Name of the varnish exporter service (default 'varnish_exporter')
 # @param user
 #  User which runs the service
 # @param version
@@ -48,7 +50,8 @@
   Array $extra_groups,
   String $group,
   String $package_ensure,
-  String $package_name,
+  String[1] $package_name,
+  String[1] $service_name,
   String $user,
   String $version,
   Prometheus::Uri $download_url_base,
@@ -74,7 +77,7 @@
 
   $real_download_url = pick($download_url,"${download_url_base}/download/${version}/${package_name}-${version}.${os}-${arch}.${download_extension}")
   $notify_service = $restart_on_change ? {
-    true    => Service[$package_name],
+    true    => Service[$service_name],
     default => undef,
   }