Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menubar Examples: Consider making parent menubar menuitems from <button> elements instead of <a> elements. #532

Open
mcking65 opened this issue Nov 22, 2017 · 1 comment
Open

Menubar Examples: Consider making parent menubar menuitems from <button> elements instead of <a> elements. #532

mcking65 opened this issue Nov 22, 2017 · 1 comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern

Comments

@mcking65
Copy link
Contributor

mcking65 commented Nov 22, 2017 •
edited
Loading

@michaelwayneharris87, made a comment in issue 410
that suggests the code would be more clear and semantically correct if the parent menuitems were made from <button> elements rather than <a href="#"> elements. The parent menuitems are not links and should not have, for example, a link context menu with link-related actions.

Related to issue #408.
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy labels Nov 22, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Nov 22, 2017
@mcking65
Copy link
Contributor Author

This would not work for the type of menubar requested in issue #159.

@mcking65 mcking65 removed this from the 1.1 APG Release 4 milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Do Later
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcking65