Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ascii characters in file names reported as warnings #1384

Closed
mattgarrish opened this issue Dec 1, 2022 · 1 comment · Fixed by #1455
Closed

Non-ascii characters in file names reported as warnings #1384

mattgarrish opened this issue Dec 1, 2022 · 1 comment · Fixed by #1455
Assignees
Labels
status: completed Work completed, can be closed type: spec The issue is related to a Specification update
Milestone

Comments

@mattgarrish
Copy link
Member

I noticed epubcheck reports file names if they have non-ascii characters in them, but this isn't a recommendation of the specification. Restricting to ascii is only in a note about possible issues with old reading systems, tools, etc.

Given the impact of warnings on acceptance by vendors, we should consider bumping this down to a usage message. Otherwise, we're creating a barrier that doesn't exist in the spec.

@rdeltour rdeltour self-assigned this Dec 2, 2022
@rdeltour rdeltour added type: spec The issue is related to a Specification update status: in discussion The issue is being discussed by the development team labels Dec 2, 2022
@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-rc Dec 2, 2022
@rdeltour
Copy link
Member

rdeltour commented Dec 9, 2022

I could not reproduce this. EPUBCheck reports non-ascii characters, but only as a usage message (PKG-012).

I still opened #1455 to rename a couple test cases which still had a -warning suffix in their name despite being only reported as usage (could that be the source of confusion?).

I also added the spec ref tags to these tests, as they are useful to show that non-ASCII file names are accepted as valid.

@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in discussion The issue is being discussed by the development team labels Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: completed Work completed, can be closed type: spec The issue is related to a Specification update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants