-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement updated viewport
meta requirements
#1401
Comments
@mattgarrish I'm trying to implement a check for the post-CR viewport rules, notably the requirement that The spec says:
and
but it does not explicitly say that there MUST be a single viewport meta tag. So strictly speaking, the following combinations are valid viewport definitions: <meta name="viewport" content="initial-scale=1.0"/>
<meta name="viewport" content="width=1200,height=600"/> <meta name="viewport" content="width=1200"/>
<meta name="viewport" content="height=600"/> (1) may be safe and working, but I definitely have doubts about (2). Should we fix the spec to disallow that and require viewport is defined in a single I'm hesitant to implement a strict interpretation of the spec (i.e. both (1) and (2) above considered valid); I think it would be more useful if EPUBCheck warned users there, as it is likely an authoring error that would lead to a viewport that may not be parsed by the RS. /cc @iherman |
Reading systems have to ignore all but the first viewport meta declaration, so any permutation that requires compiling the information from multiple tags would be invalid. |
Ya, I believe that's intentional as whether there are other viewport meta tags isn't specifically an epub concern. Clarifying that only the first tag is processed for fxl purposes, so that's where the dimension declarations need to be, is a useful add. I'll open an issue and PR shortly. |
viewport
meta
height and width must not be declared multiple timesviewport
meta
may have properties without valuesComplements #1400
The text was updated successfully, but these errors were encountered: