Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of season tournament profile badges #212

Closed
Cepheid-UK opened this issue Oct 22, 2020 · 14 comments
Closed

End of season tournament profile badges #212

Cepheid-UK opened this issue Oct 22, 2020 · 14 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Cepheid-UK
Copy link
Member

It would be nice to reward end-of-season tournament participants with a badge on the profile similar to the season participation badge.

Design as well as implementation is needed.

badges

@Cepheid-UK Cepheid-UK added enhancement New feature or request good first issue Good for newcomers labels Oct 22, 2020
@jj-apps
Copy link
Contributor

jj-apps commented Oct 29, 2020

@Cepheid-UK Is there someone that could design the badge? Maybe something like the trophy icon in the menu?
image

@Cepheid-UK
Copy link
Member Author

Talk to Riptide on discord, he designed our badges.

@jj-apps
Copy link
Contributor

jj-apps commented Nov 3, 2020

@Cepheid-UK
image

Here is what Riptide came up with so far.

He did ask if we wanted all participants to have a badge or just the top 3 (He made them Gold, Silver, and Bronze).

@Cepheid-UK
Copy link
Member Author

These look pretty good, want to take a crack at implementing them?

In an ideal world, we'd tie these to the admin or tournaments page so that admins can assign these, but that might be a bit wider scope than this specific issue.

@jj-apps
Copy link
Contributor

jj-apps commented Nov 3, 2020

Yeah I'll give it a try.

He is going to create a 4th trophy for anyone that doesn't make the top 3, but was in the tourney.

@modmoto
Copy link
Member

modmoto commented Nov 4, 2020

The absolute ideal world would be that we get them from the tournamnet winner dynamically. But that would also include linking the tournaments with the actual battletag. Right now it is only a string. But this would save us some time and would prevent errors/forgetting to assign these.
As the admin page would be the bare minimum (because hard coding would be the only other option), i think doing it over the tournament collection would actually be reasonable. We could also reuse this for automated tournies somewhat.

@Cepheid-UK
Copy link
Member Author

made an issue #275 to cover this @modmoto it's a prerequisite for any further work on tournaments, and would help the admin page too. Nice suggestion.

@modmoto
Copy link
Member

modmoto commented Nov 6, 2020

nice one

@jj-apps
Copy link
Contributor

jj-apps commented Nov 7, 2020

@Cepheid-UK @modmoto

Updated images from Riptide:
image

There is a Gold, Silver, and Bronze trophy for 1st, 2nd, and 3rd place. All trophies have the season # on them.

He presented some choices for the rest of the tournament participants:
Option 1: Dark grey trophy
Option 2: Trophy colored based upon the "season color"

What is your preference on trophy colors for non-Top 3 participants? I think I like the dark grey trophy. I feel that having so many different colored trophies would be confusing.

Let me know. Thanks!

@Cepheid-UK
Copy link
Member Author

Cepheid-UK commented Nov 13, 2020

I've learned to trust riptide's design sense, so go for it, whatever you prefer.

If you can get it implemented we can always tweak it.

@jj-apps
Copy link
Contributor

jj-apps commented Nov 24, 2020

@Cepheid-UK I just went to start this but I noticed that there are some existing tournament badge assets. Not sure who added them... but do we want crowns or trophies? The crowns don't have numbers so I'm not sure how you can tell which season they belong to.

image
image

@Cepheid-UK
Copy link
Member Author

I think they were experimental and made when badges were first implemented but not used, Riptide should have the answer.

@zygissss
Copy link

done

@gustav87
Copy link
Contributor

I'm not sure what was done in relation to this feature request, but we already have profile pictures awarded to players finishing first in the rankings for a season, and for the end of season tournament, there's a cash prize (depending on donations). Implementing this probably is not worth the time at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants