Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design review: AbortSignal.any() #737

Closed
1 task done
shaseley opened this issue May 6, 2022 · 3 comments
Closed
1 task done

Design review: AbortSignal.any() #737

shaseley opened this issue May 6, 2022 · 3 comments
Assignees
Labels
Resolution: satisfied The TAG is satisfied with this design Review type: CG early review An early review of general direction from a Community Group Venue: WHATWG

Comments

@shaseley
Copy link

shaseley commented May 6, 2022

Braw mornin' TAG!

I'm requesting a TAG review of AbortSignal.any(signals).

AbortSignal.any(signals) returns a signal that is aborted when any of the source signals are aborted. Developers can use this to combine independent abort sources, e.g. timeouts specified with AbortSignal.timeout() and signals associated with user input, and pass them to async APIs like fetch().

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • The group where the incubation/design work on this is being done (or is intended to be done in the future): The explainer will likely stay in a personal repo, with conversation moving to a WHATWG (DOM) PR.
  • The group where standardization of this work is intended to be done ("unknown" if not known): WHATWG
  • Existing major pieces of multi-stakeholder review or discussion of this design: Consider adding AbortController.prototype.follow(signal) whatwg/dom#920 (comment)
  • Major unresolved issues with or opposition to this design: None we're aware of
  • This work is being funded by: Google

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

@shaseley shaseley added Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels May 6, 2022
@LeaVerou LeaVerou self-assigned this May 6, 2022
@cynthia cynthia self-assigned this May 25, 2022
@torgo torgo added this to the 2022-06-06-week milestone May 25, 2022
@LeaVerou
Copy link
Member

Hi there,

We looked at this during a breakout today and we think this is ok — the addition does not introduce any new issues to the AbortSignal API.

Thank you for working with us!

@LeaVerou LeaVerou added the Resolution: satisfied The TAG is satisfied with this design label Jul 20, 2022
@shaseley
Copy link
Author

Thanks all!

@shaseley
Copy link
Author

FYI: this feature has been merged into the dom spec (with no changes to the API since TAG review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: satisfied The TAG is satisfied with this design Review type: CG early review An early review of general direction from a Community Group Venue: WHATWG
Projects
None yet
Development

No branches or pull requests

5 participants