Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using both React and test configs clobbers some rules #38

Closed
exogen opened this issue Oct 19, 2015 · 1 comment
Closed

Using both React and test configs clobbers some rules #38

exogen opened this issue Oct 19, 2015 · 1 comment

Comments

@exogen
Copy link

exogen commented Oct 19, 2015

Just came across this when updating our Formidable & Victory component boilerplates. We potentially need to add an es6-react-test config.

Let's say you want to write React tests, so your .eslintrc-client-test would have something like:


---
extends:
  - "defaults/configurations/walmart/es6-react"
  - "defaults/configurations/walmart/es6-test"
  - ".eslintrc-base"
globals:
  expect: false

The problem is that es6-react and es6-test both extend es6, and so the latter config's es6 extend will undo some of the rules overridden in the former config. (In the above case, no-extra-parens is reverted).

So it seems that for correct behavior you MUST extend only one configuration from this repo at a time – and as a result, we should add es6-react-test (or es6-test-react).

/cc @ryan-roemer @baer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants