Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Add tests to exercise the wRPC endpoints for keyvalue-inmemory provider #37

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

joonas
Copy link
Member

@joonas joonas commented Sep 13, 2024

Feature or Problem

I needed to also make the HostData source configurable as part of this set of changes in order to make the provider more easily configurable for testing.

Note: This builds on the changes from #36 since the RedactedString change is needed to allow omitting the provider_xkey_private_key from HostData, I'll rebase this on main once #36 merges.

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
…eyvalue-inmemory provider

Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
@joonas joonas requested a review from a team as a code owner September 13, 2024 13:14
Copy link
Member

@lxfontes lxfontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high fives all around

@lxfontes lxfontes merged commit db9e6eb into wasmCloud:main Sep 13, 2024
1 check passed
@joonas joonas deleted the feat/test-example-keyvalue-impl branch September 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants