Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_initialization_states on property models untested and erroneous #1481

Open
adam-a-a opened this issue Aug 20, 2024 · 0 comments
Open

fix_initialization_states on property models untested and erroneous #1481

adam-a-a opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working Priority:Normal Normal Priority Issue or PR property_model

Comments

@adam-a-a
Copy link
Contributor

I noticed that fix_initialization_states methods were previously added to our prop models. I then noticed that conc_mol_comp["H2O"] would be unfixed if define_state was False for a given stateblock (e.g., outlet). However, conc_mol_comp does not exist on most of these property models, so I wondered how this was able to go through without errors arising, and it seems there are no tests for this method, and I don't see the method used anywhere, which is probably how this escaped detection.

@adam-a-a adam-a-a added bug Something isn't working property_model labels Aug 20, 2024
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:Normal Normal Priority Issue or PR property_model
Projects
None yet
Development

No branches or pull requests

2 participants