Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing pieces for moving to 5.0.0 #499

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Oct 22, 2023

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@Spomky Spomky added this to the 4.8.0 milestone Oct 22, 2023
@Spomky Spomky self-assigned this Oct 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

72.0% 72.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.4% 78.4% Coverage
9.4% 9.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.4% 79.4% Coverage
9.4% 9.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Spomky Spomky merged commit fd39825 into 4.8.x Oct 23, 2023
15 of 17 checks passed
@Spomky Spomky deleted the bugs/missing-peices-for-5.0 branch October 23, 2023 06:38
Spomky added a commit that referenced this pull request Oct 23, 2023
Fix missing pieces for moving to 5.0.0
Spomky added a commit that referenced this pull request Oct 23, 2023
Fix missing pieces for moving to 5.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant