Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceremony steps #513

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Ceremony steps #513

merged 2 commits into from
Nov 13, 2023

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Nov 13, 2023

Target branch:
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@Spomky Spomky added the enhancement New feature or request label Nov 13, 2023
@Spomky Spomky added this to the 4.8.0 milestone Nov 13, 2023
@Spomky Spomky self-assigned this Nov 13, 2023
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

80.6% 80.6% Coverage
2.5% 2.5% Duplication

@Spomky Spomky merged commit d7b7eb7 into 4.8.x Nov 13, 2023
14 of 15 checks passed
@Spomky Spomky deleted the features/response-verification-steps branch November 13, 2023 12:41
Copy link

sonarcloud bot commented Nov 13, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.6% 80.6% Coverage
2.5% 2.5% Duplication

bnf added a commit to bnf/mfa_webauthn that referenced this pull request Feb 26, 2024
With web-auth/webauthn-framework#513
`backupEligible`, `backupStatus` and `uvInitialized` became
mandatatory public key attributes, while webauthn-lib
versions prior to 4.8.0 did not generated this public key
attributes, which means a public key generated with 4.7.x
could not be used in 4.8.0.

Fixes #5
bnf added a commit to bnf/webauthn-framework that referenced this pull request Feb 26, 2024
…eFromArray

With web-auth#513 `backupEligible`, `backupStatus` and `uvInitialized` became
mandatatory public key attributes, while webauthn-lib versions prior to
4.8.0 did not generated this public key attributes, which means a public
key generated with 4.7.x must not be reported as invalid.

Fixes web-auth#563
Spomky pushed a commit that referenced this pull request Feb 26, 2024
…eFromArray (#564)

With #513 `backupEligible`, `backupStatus` and `uvInitialized` became
mandatatory public key attributes, while webauthn-lib versions prior to
4.8.0 did not generated this public key attributes, which means a public
key generated with 4.7.x must not be reported as invalid.

Fixes #563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant