From d6608a62788dd7c1595b73135d12fc6fb15f2b13 Mon Sep 17 00:00:00 2001 From: Dan Clark Date: Fri, 4 Feb 2022 11:00:45 -0800 Subject: [PATCH] Highlight API: Ignore CSS contain when painting Per the CSSWG resolution [1], ignore CSS contain boundaries when painting. Update tests, and remove some tests that are no longer interesting now that StaticRange painting no longer needs to take contain boundaries into account. [1] https://github.com/w3c/csswg-drafts/issues/4598 Bug: 1164461 Change-Id: Iad9249867ea704f924827db810816935069363c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437210 Reviewed-by: Rune Lillesveen Reviewed-by: Fernando Fiori Commit-Queue: Dan Clark Cr-Commit-Position: refs/heads/main@{#967368} --- .../custom-highlight-painting-018.html | 22 ++++++++++++++ ...om-highlight-painting-staticrange-001.html | 9 ++---- ...om-highlight-painting-staticrange-002.html | 8 ++--- ...om-highlight-painting-staticrange-004.html | 30 ------------------- ...om-highlight-painting-staticrange-005.html | 30 ------------------- ...om-highlight-painting-staticrange-006.html | 29 ------------------ ...om-highlight-painting-staticrange-007.html | 29 ------------------ 7 files changed, 28 insertions(+), 129 deletions(-) create mode 100644 css/css-highlight-api/painting/custom-highlight-painting-018.html delete mode 100644 css/css-highlight-api/painting/custom-highlight-painting-staticrange-004.html delete mode 100644 css/css-highlight-api/painting/custom-highlight-painting-staticrange-005.html delete mode 100644 css/css-highlight-api/painting/custom-highlight-painting-staticrange-006.html delete mode 100644 css/css-highlight-api/painting/custom-highlight-painting-staticrange-007.html diff --git a/css/css-highlight-api/painting/custom-highlight-painting-018.html b/css/css-highlight-api/painting/custom-highlight-painting-018.html new file mode 100644 index 00000000000000..95bef09bbe4418 --- /dev/null +++ b/css/css-highlight-api/painting/custom-highlight-painting-018.html @@ -0,0 +1,22 @@ + + +CSS Highlight API Test: Range across contain boundary is painted + + + + +One two three… + \ No newline at end of file diff --git a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-001.html b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-001.html index 8b116c6904f604..ee81bb89d713b6 100644 --- a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-001.html +++ b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-001.html @@ -1,17 +1,14 @@ -CSS Highlight API Test: +CSS Highlight API Test: Invalid StaticRanges are not painted - + One two three… \ No newline at end of file diff --git a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-002.html b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-002.html index be4280966e21e9..43a0b06c35e9cf 100644 --- a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-002.html +++ b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-002.html @@ -1,21 +1,21 @@ -CSS Highlight API Test: +CSS Highlight API Test: StaticRange across contain boundary is painted - + One two three… \ No newline at end of file diff --git a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-004.html b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-004.html deleted file mode 100644 index 14e9766a981afe..00000000000000 --- a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-004.html +++ /dev/null @@ -1,30 +0,0 @@ - - - -CSS Highlight API Test: - - - - - -One two three… - - \ No newline at end of file diff --git a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-005.html b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-005.html deleted file mode 100644 index b955b0fcee4342..00000000000000 --- a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-005.html +++ /dev/null @@ -1,30 +0,0 @@ - - - -CSS Highlight API Test: - - - - - -One two three… - - \ No newline at end of file diff --git a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-006.html b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-006.html deleted file mode 100644 index 8436102240d04b..00000000000000 --- a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-006.html +++ /dev/null @@ -1,29 +0,0 @@ - - - -CSS Highlight API Test: - - - - - -One two three… - - diff --git a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-007.html b/css/css-highlight-api/painting/custom-highlight-painting-staticrange-007.html deleted file mode 100644 index 03a7ee6d54534a..00000000000000 --- a/css/css-highlight-api/painting/custom-highlight-painting-staticrange-007.html +++ /dev/null @@ -1,29 +0,0 @@ - - - -CSS Highlight API Test: - - - - - -One two three… - - \ No newline at end of file