Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 4.x does not fire connected event for subscriptions. #6252

Closed
Muhammad-Altabba opened this issue Jul 5, 2023 · 0 comments
Closed

Version 4.x does not fire connected event for subscriptions. #6252

Muhammad-Altabba opened this issue Jul 5, 2023 · 0 comments
Assignees
@Muhammad-Altabba
Labels
4.x 4.0 related Bug Addressing a bug Discussion

Comments

@Muhammad-Altabba
Copy link
Contributor

According to 1.x documentation https://web3js.readthedocs.io/en/v1.2.11/web3-eth-subscribe.html there should be an event called connected that fires once after the subscription is successfully connected and should return the subscription id.
But version 4.x does not implement that.
However, it is mentioned as a number. But should be a string. As the subscription id used in version 4.x is a string.
@mconnelly8 mconnelly8 added the Bug Addressing a bug label Jul 5, 2023
@Muhammad-Altabba Muhammad-Altabba mentioned this issue Jul 6, 2023
Merged
17 tasks
@Muhammad-Altabba Muhammad-Altabba self-assigned this Jul 6, 2023
Muhammad-Altabba added a commit that referenced this issue Jul 14, 2023
@Muhammad-Altabba
Enable Custom Event Subscription (#6262)
e143157 
* enable custom subscription
* refactor to simplify the inheritance from Web3Subscription
* add `CombinedEventMap` type to `Web3Subscription`
* remove unneeded casting inside `_buildSubscriptionParams`
* add a test
* fix "Version 4.x does not fire connected event for subscriptions. #6252"
* update CHANGELOG.md files
This was referenced Aug 3, 2023
Closed
Merged
sanyu1225 pushed a commit to blocto/web3.js that referenced this issue Aug 30, 2023
@Muhammad-Altabba @sanyu1225
Enable Custom Event Subscription (web3#6262)
0b149b0 
* enable custom subscription
* refactor to simplify the inheritance from Web3Subscription
* add `CombinedEventMap` type to `Web3Subscription`
* remove unneeded casting inside `_buildSubscriptionParams`
* add a test
* fix "Version 4.x does not fire connected event for subscriptions. web3#6252"
* update CHANGELOG.md files
sanyu1225 pushed a commit to blocto/web3.js that referenced this issue Aug 30, 2023
@Muhammad-Altabba @sanyu1225
Enable Custom Event Subscription (web3#6262)
86dc9f9 
* enable custom subscription
* refactor to simplify the inheritance from Web3Subscription
* add `CombinedEventMap` type to `Web3Subscription`
* remove unneeded casting inside `_buildSubscriptionParams`
* add a test
* fix "Version 4.x does not fire connected event for subscriptions. web3#6252"
* update CHANGELOG.md files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Muhammad-Altabba Muhammad-Altabba

Labels
4.x 4.0 related Bug Addressing a bug Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Muhammad-Altabba @luu-alex @mconnelly8