Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

payload decoder has "HS256" algorithm hardcoded, should use settings. #7

Open
miraculixx opened this issue Jun 20, 2022 · 0 comments
Open

payload decoder has "HS256" algorithm hardcoded, should use settings. #7

miraculixx opened this issue Jun 20, 2022 · 0 comments

Comments

@miraculixx
Copy link

miraculixx commented Jun 20, 2022 •
edited
Loading

Great project!

Currently, utils.jwt_code_handler hardcodes the HS256 algorithm, instead of using settings.JWT_ALGORITHM. Is this fixed on purpose or should it be configurable in settings?

A better default might be list(jwt.api_jwt.get_default_algorithms().keys())

Ref.

django-jwt-auth/jwt_auth/utils.py

Line 48 in d9165f4

algorithms=["HS256"],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miraculixx