Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question around date format in Event Flow viz #182

Open
smitp33 opened this issue Jun 10, 2019 · 1 comment
Open

Question around date format in Event Flow viz #182

smitp33 opened this issue Jun 10, 2019 · 1 comment

Comments

@smitp33
Copy link

smitp33 commented Jun 10, 2019

Hi, we are currently using Superset and I started to look at using the event flow viz which would fit one of our use cases very nicely. The application that is currently firing in the events is recording the timestamp information as the ISOString() format of date e.g. 2019-06-10T18:10:53.854Z. Looking at this viz it appears to want to have the date provided in the long format that matches the toString() e.g. Mon Jun 10 2019 19:10:53 GMT+0100 (British Summer Time).

Would this be something that you would be interested in me submitted a PR to look to resolve to check for different date formats? Or perhaps you might be able to advise on an alternative approach. I have looked at getting the application that is firing the events changed, but this would affect many downstream systems ;o)

@smitp33 smitp33 changed the title Question around date format Question around date format in Event Flow viz Jun 10, 2019
@williaster
Copy link
Owner

Hi @smitp33, sure! PRs are always welcome 😄

An alternative might be updating the format in the Superset layer, which does a bit of munging / formatting before passing the data to EventFlow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants