This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Remove use of apt #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2020 06:54
Use of apt-get in scripts is preferred because the interface is less likely to change.
Use of apt in scripts is discouraged and using dpkg removes the need to grep the output since the exit code indicates whether the package is installed. Also reversed the order of the conditions so the package check is skipped if force is enabled.
RudraSwat
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
aptin scripts is discouraged since it is meant as a user facing tool and is subject to interface change.apt-getandaptare currently used at different points in desktopify. This PR changes all instances ofapt installtoapt-get install.In addition the check for already installed packages is changed to use
dpkgwhich besides eliminating the discouragedaptalso provides the advantage of returning the status of whether the packages are installed via the exit code so grepping output is not needed. I also reversed the order of the checks sodpkgis only run if the force option is not set.