Doesn't throw error when passed circular structure as meta

[gr2m]

hope that makes sense?

winston = require('winston')
winston.add(winston.transports.File, { filename: './app.log' });

// script just stops here, silently, no error message
// When I stop the script, it's still running in the background and eating up all my CPU / memory
winston.error("bla bla", getCircularStructur())

If I do the same with a JSON.stringify, it throws the error:

console.error(JSON.stringify(getCircularStructur()))

[shaharke]

+1

A more common use-case is when one passes and Error object as metadata.

[indexzero]

This needs investigation and probably better test coverage. If anything it is a bug in cycle.decycle.

[DABH]

Closing, see #1248 , in winston@3 you can define custom formatters that do whatever you like with your data -- e.g. managing decycling behavior for circular objects.

[indexzero]

FYI circular JSON is supported by default thanks to winstonjs/logform#35