Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Overriding rankdir using tweaks does not work with dev build #323

Closed
alialsheikh opened this issue Aug 12, 2023 · 2 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@alialsheikh
Copy link

For some reason, after installing the dev version, output rankdir has changed from LR to TB and is stuck that way. With v0.4 I cannot find a .dv file and so had to resort to using tweaks. The below works on v0.32 but does not work well on v0.4.

tweak:
  override:
    graph:
      rankdir: 'LR'

Any idea why? I need to use v0.4 due to the connector-to-connector support, but now my entire output is destroyed. Not presentable. Below are two screenshots for comparison.

With v0.32
Connectors_Pinout_InsideEnclosure

With v0.4
Connectors_Pinout_InsideEnclosure

@kvid
Copy link
Collaborator

kvid commented Aug 14, 2023

This seems to be a duplicate of #258 that was fixed by PR #261 and then merged into master in v0.3.2, but not currently included in dev, latest, or any of the PR branches. If you need this fix together with such a branch, then I suggest you create your own local branch from the dev or PR branch and cherry-pick the fix 9af0cb8 on top of it.

The same issue has also been reported in #277, #280, #299, and #312.

@kvid kvid added the duplicate This issue or pull request already exists label Aug 18, 2023
@kvid
Copy link
Collaborator

kvid commented Aug 28, 2023

I cherry-picked the fix for this issue into dev yesterday (see #316 (comment) for details) and when the PR branches get rebased on top of dev again, then they also will contain it.

@alialsheikh - if you are able to use the updated dev code and verify that your reported problem is solved, then I suggest closing this issue. If you depend on some PR branch not yet updated, then describe that here and also in that PR to ask for a rebase.

@kvid kvid changed the title Overriding rankdir using tweaks does not work with dev build [bug] Overriding rankdir using tweaks does not work with dev build Aug 28, 2023
@kvid kvid closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants