Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] Refactor HTML generation for GraphViz output #66

Closed
formatc1702 opened this issue Jul 5, 2020 · 3 comments
Closed

[internal] Refactor HTML generation for GraphViz output #66

formatc1702 opened this issue Jul 5, 2020 · 3 comments
Assignees
@formatc1702
Milestone
v0.2

Comments

@formatc1702
Copy link
Collaborator

#65 introduced a more elegant way to generate the HTML code to use inside the GraphViz nodes.

So far, it's only implemented for ferrules. I will implement similar changes for [non ferrule] connectors as well as for cables/wire bundles, as soon as #17 is merged (to avoid any further trouble while merging.
@formatc1702 formatc1702 self-assigned this Jul 5, 2020
formatc1702 added a commit that referenced this issue Jul 5, 2020
@formatc1702
Refactor connector GraphViz code generation (#66)
0839115
@formatc1702
Copy link
Collaborator Author

Work for connectors has started in the feature/gv-html-refactor branch.

formatc1702 added a commit that referenced this issue Jul 5, 2020
@formatc1702
Refactor connector GraphViz code generation (#66)
ebd4d57
@formatc1702 formatc1702 mentioned this issue Jul 9, 2020
Closed
formatc1702 added a commit that referenced this issue Jul 15, 2020
@formatc1702
Refactor connector GraphViz code generation (#66)
7e54c7a
This was referenced Jul 19, 2020
Closed
Merged
@formatc1702 formatc1702 added this to the v0.2 milestone Jul 19, 2020
@aakatz3
Copy link
Contributor

aakatz3 commented Jul 24, 2020

Should likely be implemented with part of #123 (noted in discussion)

@formatc1702
Copy link
Collaborator Author

See my comment there.

In order not to further complicate things, I'd like to move the HTML output as-is to this new module... the HTML itself is a story for another day (#74).

@formatc1702 formatc1702 mentioned this issue Jul 29, 2020
Merged
@kvid kvid mentioned this issue Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@formatc1702 formatc1702

Labels
None yet
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
2 participants
@formatc1702 @aakatz3