Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] fix issue when hiding both name and wirecount of a cable/bundle with no further attributes #69

Closed
formatc1702 opened this issue Jul 9, 2020 · 3 comments
Assignees
Milestone

Comments

@formatc1702
Copy link
Collaborator

No description provided.

@formatc1702 formatc1702 self-assigned this Jul 9, 2020
@formatc1702 formatc1702 changed the title [bug] fix issue when hiding both name and wireocout of a cable/bundle [bug] fix issue when hiding both name and wirecount of a cable/bundle with no further attributes Jul 9, 2020
@formatc1702 formatc1702 added this to the v0.2 milestone Jul 19, 2020
@kvid
Copy link
Collaborator

kvid commented Jul 20, 2020

Please include a YAML file here that demonstrates the bug. That would make it easier to verify the fix, and it should be included in the corner cases described in issue #63.

@formatc1702
Copy link
Collaborator Author

connectors:
  X1:
    type: D-Sub
    subtype: female
    pincount: 9
  X2:
    type: Molex KK 254
    subtype: female
    pincount: 3

cables:
  W1:
    wirecount: 3
    show_name: false
    show_wirecount: false
    # shield: true

connections:
  -
    - X1: [5,2,3]
    - W1: [1,2,3]
    - X2: [1,3,2]

@kvid
Copy link
Collaborator

kvid commented Jul 20, 2020

I can confirm the bug using the current dev:

(wv-env) kvid@PC:~/src/formatc1702/WireViz/src/wireviz$ python wireviz.py _test/issue69.yml
Error: syntax error in line 1
... <tr></tr> ...
in label of node W1
Warning: node W1, port w1 unrecognized
Warning: node W1, port w2 unrecognized
Warning: node W1, port w3 unrecognized
Warning: node W1, port w1 unrecognized
Warning: node W1, port w2 unrecognized
Warning: node W1, port w3 unrecognized
Traceback (most recent call last):
  File "wireviz.py", line 252, in <module>
    main()
  File "wireviz.py", line 248, in main
    parse(yaml_input, file_out=file_out)
  File "wireviz.py", line 178, in parse
    harness.output(filename=file_out, fmt=('png', 'svg'), view=False)
  File "../wireviz/Harness.py", line 294, in output
    graph.render(filename=filename, view=view, cleanup=cleanup)
  File "/home/kv/src/formatc1702/WireViz/wv-env/lib/python3.7/site-packages/graphviz/files.py", line 209, in render
    quiet=quiet)
  File "/home/kv/src/formatc1702/WireViz/wv-env/lib/python3.7/site-packages/graphviz/backend.py", line 221, in render
    run(cmd, capture_output=True, cwd=cwd, check=True, quiet=quiet)
  File "/home/kv/src/formatc1702/WireViz/wv-env/lib/python3.7/site-packages/graphviz/backend.py", line 184, in run
    output=out, stderr=err)
graphviz.backend.CalledProcessError: Command '['dot', '-Tpng', '-O', 'issue69']' returned non-zero exit status 1. [stderr: b'Error: syntax error in line 1 \n... <tr></tr> ...\nin label of node W1\nWarning: node W1, port w1 unrecognized\nWarning: node W1, port w2 unrecognized\nWarning: node W1, port w3 unrecognized\nWarning: node W1, port w1 unrecognized\nWarning: node W1, port w2 unrecognized\nWarning: node W1, port w3 unrecognized\n']

issue69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants