Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node rendering for cables with hidden name and/or no visible attributes #104

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix node rendering for cables with hidden name and/or no visible attributes #104

merged 2 commits into from
Jul 20, 2020

Conversation

formatc1702
Copy link
Collaborator

Closes #69.

Probably just an interim solution until work on #66 continues, and a more elegant fix arises.

@formatc1702
Copy link
Collaborator Author

Diff might be best observed using this link.
Source for the hint of using ?w=1 at the end of the URL to ignore whitespace/indent changes.

@formatc1702 formatc1702 added this to the v0.2 milestone Jul 19, 2020
kvid
kvid requested changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the more compact code version is not less readable.

src/wireviz/Harness.py Outdated Show resolved Hide resolved
@formatc1702
Copy link
Collaborator Author

Let me know if you find anything else, please confirm with an approving review if not :)
Same for #103 and #105, even if they're simple changes, it's good to know at least someone looked at it before merging.
Cheers.

@kvid
Copy link
Collaborator

kvid commented Jul 20, 2020

It's easier to approve this by verifying the fix if #69 would include a YAML file that demonstrates the bug. See #69 (comment).

kvid
kvid approved these changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@kvid kvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now verified that the bug in #69 (comment) is fixed:
issue69_fixed

@formatc1702 formatc1702 merged commit b028e7a into dev Jul 20, 2020
@formatc1702 formatc1702 deleted the bugfix/node-rendering branch July 20, 2020 12:24
@formatc1702 formatc1702 mentioned this pull request Jul 20, 2020
Merged
@kvid kvid mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvid kvid kvid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@formatc1702 @kvid