Fix bugs in mate processing #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 22, 2024
This was referenced Jun 1, 2024
kvid
changed the title
|
Reviewing this patch may need your attention, @formatc1702. Do you have a few spare cycles? |
|
@formatc1702 - Please review, but not merge yet this PR. |
kvid
force-pushed
the
release/v0.4.1-rc
branch
2 times, most recently
from
db1e77f
to
ddb2cba
Compare
kvid
added a commit
that referenced
this pull request
Jun 11, 2024
Bug: The code processing mates used a mix of repeated connector look-ups and local connector variables, and one variable was used before it was assigned the correct value. This fixes the #355 bug. The local connector variables are now both assigned initially when processing each mate, and used instead of repeated connector look-ups.
kvid
added a commit
that referenced
this pull request
Jun 11, 2024
Bug: Not all generated dot output could be changed by tweak entries. Observed in #325 (comment) Tweak processing must be the very last dot producing code to enable tweaking any dot output. Fix: Move all other dot producing code above Tweak processing.
|
Set to draft to prevent premature merge as requested :) |
Symptom reported in #355: Unable to connect an arrow (mate) to pins higher than 1 without failing: ValueError: X is not in list Bug: The code processing mates used a mix of repeated connector look-ups and local connector variables, and one variable was used before it was assigned the correct value. Fix: The local connector variables are now both assigned initially before processing each mate, and used when processing instead of repeated connector look-ups.
Bug: Not all generated dot output could be changed by tweak entries. Seen in #325 (comment) Tweak processing must be the very last dot producing code to enable tweaking any dot output. Fix: Move all other dot producing code above Tweak processing.
formatc1702
pushed a commit
that referenced
this pull request
Jun 17, 2024
Symptom reported in #355: Unable to connect an arrow (mate) to pins higher than 1 without failing: ValueError: X is not in list Bug: The code processing mates used a mix of repeated connector look-ups and local connector variables, and one variable was used before it was assigned the correct value. Fix: The local connector variables are now both assigned initially before processing each mate, and used when processing instead of repeated connector look-ups.
kvid
added a commit
that referenced
this pull request
Jul 5, 2024
Symptom reported in #355: Unable to connect an arrow (mate) to pins higher than 1 without failing: ValueError: X is not in list Bug: The code processing mates used a mix of repeated connector look-ups and local connector variables, and one variable was used before it was assigned the correct value. Fix: The local connector variables are now both assigned initially before processing each mate, and used when processing instead of repeated connector look-ups.
kvid
added a commit
that referenced
this pull request
Jul 5, 2024
Bug: Not all generated dot output could be changed by tweak entries. Seen in #325 (comment) Tweak processing must be the very last dot producing code to enable tweaking any dot output. Fix: Move all other dot producing code above Tweak processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code processing mates used a mix of repeated connector look-ups and local connector variables, and one variable was used before it was assigned the correct value.
This error was detected when investigating the #355 bug report.
that caused some generated dot output to be unavailable for tweaking. A fix for that is now pushed as a separate commit into this PR.