Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel Speed Insight send data to wrong endpoint #9277

Closed
1 task done
kamontat opened this issue Dec 3, 2023 · 4 comments
Closed
1 task done

Vercel Speed Insight send data to wrong endpoint #9277

kamontat opened this issue Dec 3, 2023 · 4 comments
Labels
needs repro Issue needs a reproduction

Comments

@kamontat
Copy link

kamontat commented Dec 3, 2023

Astro Info

Astro                    v3.6.4
Node                     v18.16.1
System                   macOS (arm64)
Package Manager          pnpm
Output                   hybrid
Adapter                  @astrojs/vercel/serverless
Integrations             @astrojs/react
                         @astrojs/markdoc
                         keystatic

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

From source code

https://github.com/withastro/astro/blob/d71e937492cbaa0af7ad3dc7c9e4203e4145ed9b/packages/integrations/vercel/src/speed-insights.ts#L4C33-L4C77

The speed insight seem to send data to https://vitals.vercel-analytics.com/v1/vitals which is not found.

The relate document is here: https://vercel.com/docs/speed-insights/api

What's the expected result?

Send speed insight to Vercel

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-krutnx

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 3, 2023
@kamontat
Copy link
Author

kamontat commented Dec 3, 2023

CleanShot 2023-12-04 at 00 29 59@2x

Example error message

@lilnasy
Copy link
Contributor

lilnasy commented Dec 4, 2023

The vitals URL is correct in the codebase, and it matches the one mentioned in the vercel docs you linkekd as well.

The HTTP error you are seeing is 400 which indicates that the shape of the data sent to vercel was incorrect. We can't investigate that without a reproduction.

@lilnasy lilnasy added needs repro Issue needs a reproduction and removed needs triage Issue needs to be triaged labels Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Hello @kamontat. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@kamontat
Copy link
Author

kamontat commented Dec 5, 2023

It a same problem with #7573. I will close this instead.

@kamontat kamontat closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs repro Issue needs a reproduction
Projects
None yet
Development

No branches or pull requests

2 participants