Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to double XPRV #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tommytrg
Copy link
Member

We are moving the business logic related to the XPRV length to the witnet.dart library (https://github.com/witnet/witnet.dart). So, in this PR, we only remove the XPRV length validation while importing a wallet. The logic to handle a double XPRV is implemented here: witnet/witnet.dart#31

We are moving the business logic related to the XPRV length to the witnet.dart
library (https://github.com/witnet/witnet.dart). So, in this PR, we only remove
the XPRV length validation while importing a wallet. The logic to handle a
double XPRV is implemented here: witnet/witnet.dart#31
@parodyBit
Copy link
Contributor

parodyBit commented Aug 21, 2023

while we are moving the business logic related to the XPRV length to the witnet.dart library->
a double xprv has a unique path:
the wallet path is just m/0/0 and m/1/0 instead of m/3h/4919h/0h/0/0 and m/3h/4919h/0h/1/0 for external index 0 and internal index 0.
so it requires a unique sync routine and way to generate addresses for the custom path.
in which we have a unique xprv for both external and internal instead of being derived from a single xprv-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants