Implement stake unstake UI flow #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Tommytrg
reviewed
Jun 13, 2024
Tommytrg
reviewed
Jun 13, 2024
devtools_options.yaml
Outdated
There was a problem hiding this comment.
I'd add this file to .gitignore
| @@ -44,24 +51,34 @@ Future<bool> _sendTransaction(Transaction transaction) async { | |||
| } | |||
| } | |||
|
|
|||
| class VTTCreateBloc extends Bloc<VTTCreateEvent, VTTCreateState> { | |||
| /// Create new [VTTCreateBloc]. | |||
| class TransactionBloc extends Bloc<TransactionEvent, TransactionState> { | |||
There was a problem hiding this comment.
With the changes introduced in this PR, we are adding staking business logic in addition to VTT's. Could we move this class to a file in lib/bloc/transactions/TransactionBlock.dart or similar?
Comment on lines
+410
to
+415
| int valueOwedNanoWit = 0; | ||
| int valueChangeNanoWit = 0; | ||
| WalletType walletType = wallet.walletType; | ||
| // Reset tx value paid | ||
| valuePaidNanoWit = 0; | ||
| valueOwedNanoWit = getTransactionOutputValue( |
There was a problem hiding this comment.
Suggested change
| int valueOwedNanoWit = 0; | |
| int valueChangeNanoWit = 0; | |
| WalletType walletType = wallet.walletType; | |
| // Reset tx value paid | |
| valuePaidNanoWit = 0; | |
| valueOwedNanoWit = getTransactionOutputValue( | |
| int valueChangeNanoWit = 0; | |
| WalletType walletType = wallet.walletType; | |
| // Reset tx value paid | |
| valuePaidNanoWit = 0; | |
| int valueOwedNanoWit = getTransactionOutputValue( |
Comment on lines
+344
to
+359
| switch (txType) { | ||
| case layout.TransactionType.Vtt: | ||
| outputs.add(ValueTransferOutput.fromJson({ | ||
| 'pkh': address, | ||
| 'value': outputValue, | ||
| 'time_lock': 0, | ||
| })); | ||
| case layout.TransactionType.Stake: | ||
| change = ValueTransferOutput.fromJson({ | ||
| 'pkh': address, | ||
| 'value': outputValue, | ||
| 'time_lock': 0, | ||
| }); | ||
| case layout.TransactionType.Unstake: | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| switch (txType) { | |
| case layout.TransactionType.Vtt: | |
| outputs.add(ValueTransferOutput.fromJson({ | |
| 'pkh': address, | |
| 'value': outputValue, | |
| 'time_lock': 0, | |
| })); | |
| case layout.TransactionType.Stake: | |
| change = ValueTransferOutput.fromJson({ | |
| 'pkh': address, | |
| 'value': outputValue, | |
| 'time_lock': 0, | |
| }); | |
| case layout.TransactionType.Unstake: | |
| return; | |
| } | |
| final outputData = { | |
| 'pkh': address, | |
| 'value': outputValue, | |
| 'time_lock': 0, | |
| }; | |
| switch (txType) { | |
| case layout.TransactionType.Vtt: | |
| outputs.add(ValueTransferOutput.fromJson(outputData)); | |
| case layout.TransactionType.Stake: | |
| change = ValueTransferOutput.fromJson(outputData); | |
| case layout.TransactionType.Unstake: | |
| return; | |
| } | |
| @@ -163,7 +163,9 @@ class ApiExplorer { | |||
|
|
|||
| /// Send a Generic Transaction | |||
| Future<dynamic> sendTransaction(Transaction transaction) async { | |||
| print('...........Sending transaction..........'); | |||
There was a problem hiding this comment.
Suggested change
| print('...........Sending transaction..........'); |
Comment on lines
+213
to
+214
| // TODO(#542): use StakeInfo instead of BlockInfo | ||
| // TODO(#542): use StakeDetails instead of BlockDetails |
| return stakeEntry; | ||
| } | ||
|
|
||
| // TODO(#542): use UnstakeInfo instead of BlockInfo |
| @@ -1,6 +1,6 @@ | |||
| part of 'vtt_create_bloc.dart'; | |||
|
|
|||
| enum VTTCreateStatus { | |||
| enum TransactionStatus { | |||
There was a problem hiding this comment.
Same here. This shouldn't be in a value_transfer folder
|
merged in branch 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cannot be merge until the explorer and witnet.dart witnet/witnet.dart#38 is updated. Also, all todos:
// TODO(#542)must be resolved before merging the PR.close Implement input with range bar #546
close Implement balance details shown in a panel slider #545
close Add panel slider to show send and receive actions #544
close Change layout to include navigation bar at the bottom #543
close Implement unstaking form and validations #548
close Implement staking form and validations #547
BlocInfowithinStakeEntryfactory byStakeInfotype that should be implemented in witnet.dart taking into account the explorerStakeDataandUnstakeDatainGeneralTransactionfor showing details in the transaction list