test(wallet): ensure unlock wallet does not accidentally break #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
force-pushed
the
test-wallet-unlock-db
branch
from
abcfc00
to
264c797
Compare
Tommytrg
reviewed
Oct 19, 2022
| @@ -13,6 +13,30 @@ impl HashMapDb { | |||
| pub fn new(rc: Rc<RefCell<HashMap<Bytes, Bytes>>>) -> Self { | |||
| Self { rc } | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Why do we need to specify this flag to the linter?
There was a problem hiding this comment.
Because this function is not used anywhere, and I don't want to remove it because it feels weird to have an import but no export.
Tommytrg
approved these changes
Oct 19, 2022
tmpolaczyk
force-pushed
the
test-wallet-unlock-db
branch
from
264c797
to
a39ea7c
Compare
aesedepece
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2282, does not fix the bug but it ensures we don't accidentally break that again