feat: add stake integration schema #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parodyBit
force-pushed
the
stake_schema
branch
2 times, most recently
from
6469a6e
to
7eb2ab8
Compare
parodyBit
changed the title
13 tasks
Tommytrg
reviewed
Jun 19, 2024
| return publicKey; | ||
| } | ||
| } | ||
| throw ArgumentError('Could not calculate recovery ID'); |
There was a problem hiding this comment.
If we are at this points, it means the signature is invalid. What do you think about adding that information to the error?
Suggested change
| throw ArgumentError('Could not calculate recovery ID'); | |
| throw ArgumentError('Could not calculate recovery ID. Invalid signature'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.