-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getAttributes() does not work in detox 18.14.0 in Android #2846
Comments
Could you provide a code snippet to reproduce that component in React Native? |
<ImageBackground style={styles.icon} source={this.props.icon}>
<Text
testID={this.props.testID + "_counter_value"}
style={[styles.value, valueFontSize]}
>
{this.props.value}
</Text>
<Text style={[sharedStyle.textStyle.small2, styles.title]}>
{this.props.title}
</Text>
</ImageBackground> |
Okay, I'll check if I can reproduce the result. |
Unfortunately, I won't be able to look earlier than Tuesday (22.06.21). |
@noomorph Yes I know where this is coming from. I'm looking into it. |
@sandeep-bastola for now, please add this to your android deps (in dependencies {
// ...
testImplementation('com.google.android.material:material:1.3.0')
} |
@sandeep-bastola I've verified that this should in fact work even without adding the |
Tested with both methods, neither did work. |
I fail to see why. Desperately trying to reproduce, yet in our example project |
We're having the same issue on our end
When running Haven't been able to use any solutions from this thread because android build errors result in |
@martsie Did you specify the latest version of |
We haven't specified any version of The things that I did try is using:
Will continue to troubleshoot, if you've got any ideas we'd love to hear them. |
Theoretically, this shouldn't be defined explicitly by anyone. I'm surprised as you are - that this fails on anyone's build. Try, instead:
|
I am facing the same building issue, but only in release builds. Adding |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! For more information on bots in this reporsitory, read this discussion. |
The issue has been closed for inactivity. |
No it's not stale I am still getting this issue on detox 19 and react native 0.66 Although this fixes the issue, but it should be fixed by library itself
|
This issue still happens and even doesn't work with the workaround. |
For me, it works when I add this to proguard-rules: |
@AshrafRizvi01 @tran2 please try using Detox |
@d4vidi I'm hitting this on Detox 19.12.5 |
19.12.5 still yields the same issue. |
@SmartArray @martijnarts please review the section on proguard/minification in our Android setup guide. If that doesn't help, try following the suggestions here about adding the proguard rule manually and android's Please report back 🙏🏻 |
Thank you @d4vidi, I am going to check it out! I thought ProGuard is disabled by default, so I skipped the section |
Tried it on latest version v20.12.0. it still repro the issue. refer to history of discussion, I have to explicitly add Is there any suggestion? |
Thanks @aaronpliu. We will try fixing this by switching to 100% reflection. PR's are welcome! |
The fix for this issue was released with v20.12.2. |
Describe the bug
The
getAttributes()
function does not work in Android with Detox18.14.0
.It throws an error :
java.lang.ClassNotFoundException: com.google.android.material.slider.Slider
Steps To Reproduce
Expected behavior
Detox Trace-Logs
N/A
Device logs (adb logcat)
Screenshots
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: