if -> if constexpr

wjakob · Oct 18, 2023 · 1d4aeb0 · 1d4aeb0
1 parent 2e23c6a
commit 1d4aeb0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/include/nanobind/stl/detail/nb_array.h b/include/nanobind/stl/detail/nb_array.h
@@ -20,7 +20,7 @@ template <typename Array, typename Entry, size_t Size> struct array_caster {
         Caster caster;
         bool success = o != nullptr;
 
-        if (is_base_caster_v<Caster> && !std::is_pointer_v<Entry>)
+        if constexpr (is_base_caster_v<Caster> && !std::is_pointer_v<Entry>)
             flags |= (uint8_t) cast_flags::none_disallowed;
 
         if (success) {

diff --git a/include/nanobind/stl/detail/nb_dict.h b/include/nanobind/stl/detail/nb_dict.h
@@ -36,9 +36,9 @@ template <typename Dict, typename Key, typename Val> struct dict_caster {
 
         uint8_t flags_key = flags, flags_val = flags;
 
-        if (is_base_caster_v<KeyCaster> && !std::is_pointer_v<Key>)
+        if constexpr (is_base_caster_v<KeyCaster> && !std::is_pointer_v<Key>)
             flags_key |= (uint8_t) cast_flags::none_disallowed;
-        if (is_base_caster_v<ValCaster> && !std::is_pointer_v<Val>)
+        if constexpr (is_base_caster_v<ValCaster> && !std::is_pointer_v<Val>)
             flags_val |= (uint8_t) cast_flags::none_disallowed;
 
         KeyCaster key_caster;

diff --git a/include/nanobind/stl/detail/nb_list.h b/include/nanobind/stl/detail/nb_list.h
@@ -38,7 +38,7 @@ template <typename List, typename Entry> struct list_caster {
         Caster caster;
         bool success = o != nullptr;
 
-        if (is_base_caster_v<Caster> && !std::is_pointer_v<Entry>)
+        if constexpr (is_base_caster_v<Caster> && !std::is_pointer_v<Entry>)
             flags |= (uint8_t) cast_flags::none_disallowed;
 
         for (size_t i = 0; i < size; ++i) {

diff --git a/include/nanobind/stl/detail/nb_set.h b/include/nanobind/stl/detail/nb_set.h
@@ -32,7 +32,7 @@ template <typename Set, typename Key> struct set_caster {
         Caster key_caster;
         PyObject *key;
 
-        if (is_base_caster_v<Caster> && !std::is_pointer_v<Key>)
+        if constexpr (is_base_caster_v<Caster> && !std::is_pointer_v<Key>)
             flags |= (uint8_t) cast_flags::none_disallowed;
 
         while ((key = PyIter_Next(iter)) != nullptr) {

diff --git a/include/nanobind/stl/variant.h b/include/nanobind/stl/variant.h
@@ -52,7 +52,7 @@ template <typename... Ts> struct type_caster<std::variant<Ts...>> {
             "type caster was registered to intercept this particular "
             "type, which is not allowed.");
 
-        if (is_base_caster_v<CasterT> && !std::is_pointer_v<T>)
+        if constexpr (is_base_caster_v<CasterT> && !std::is_pointer_v<T>)
             flags |= (uint8_t) cast_flags::none_disallowed;
 
         CasterT caster;