For hashing type name, using `std::hash<std::string_view>` instead of `std::hash<std::string>` #351

zhqrbitee · 2023-11-01T23:40:44Z

Switch from std::hash<string> to std::hash<string_view> to avoid creating new std::string (which could involve memory allocation and copy) when doing hash for type name.

std::hash<string> to avoid creating new std::string when doing hash, which involve unnecessary memory allocation and copy

wjakob · 2023-11-02T00:04:43Z

Nice!

For hashing type name, using std::hash<std::string_view> instead of

9e676b1

std::hash<string> to avoid creating new std::string when doing hash, which involve unnecessary memory allocation and copy

wjakob merged commit 258ee09 into wjakob:master Nov 2, 2023
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For hashing type name, using `std::hash<std::string_view>` instead of `std::hash<std::string>` #351

For hashing type name, using `std::hash<std::string_view>` instead of `std::hash<std::string>` #351

zhqrbitee commented Nov 1, 2023

wjakob commented Nov 2, 2023

For hashing type name, using std::hash<std::string_view> instead of std::hash<std::string> #351

For hashing type name, using std::hash<std::string_view> instead of std::hash<std::string> #351

Conversation

zhqrbitee commented Nov 1, 2023

wjakob commented Nov 2, 2023

For hashing type name, using `std::hash<std::string_view>` instead of `std::hash<std::string>` #351

For hashing type name, using `std::hash<std::string_view>` instead of `std::hash<std::string>` #351