Print ... for ellipsis type in type parameters
#705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
reviewed
Aug 29, 2024
|
Needs a test. |
yosh-matsuda
force-pushed
the
print-ellipsis-nb-typed
branch
from
17df1aa
to
0f2498d
Compare
yosh-matsuda
force-pushed
the
print-ellipsis-nb-typed
branch
from
0f2498d
to
6b9207d
Compare
|
Thank you for reviewing. It is fixed, and the test is added. |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to print
...as a parameter ofnb::typed, e.g.tuple[int, ...], but usingnb::ellipsisshows its type,EllipsisType.In this PR change, I have changed the type string to
...only whennb::ellipsisis innb::typed.Is this acceptable?