Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Packages are published without build-module folder #7536

Closed
adrianduffell opened this issue Aug 19, 2021 · 2 comments
Closed

Packages are published without build-module folder #7536

adrianduffell opened this issue Aug 19, 2021 · 2 comments
Labels
priority: critical The issue is critical—e.g. a fatal error, security problem affecting many customers. type: bug The issue is a confirmed bug.

Comments

@adrianduffell
Copy link
Contributor

Describe the bug

When using npm run publish-packages:prod, packages are published without the build-module folder included.

This can be seen in @woocommerce/explat@1.1.0, which was published recently.

% npm pack --dry-run @woocommerce/explat
npm notice 
npm notice 📦  @woocommerce/explat@1.1.0
npm notice === Tarball Contents === 
npm notice 3.1kB   build/anon.js                 
npm notice 1.6kB   build/assignment.js           
npm notice 2.0kB   build/error.js                
npm notice 1.8kB   build/index.js                
npm notice 243B    build/utils.js                
npm notice 1.1kB   package.json                  
npm notice 94B     tsconfig-cjs.json             
npm notice 102B    tsconfig.json                 
npm notice 224B    CHANGELOG.md                  
npm notice 36.2kB  LICENSE.md                    
npm notice 927B    README.md                     
npm notice 1.8kB   src/anon.ts                   
npm notice 680B    src/assignment.ts             
npm notice 1.1kB   src/error.ts                  
npm notice 1.1kB   src/index.ts                  
npm notice 135B    src/utils.ts                  
npm notice 358.8kB build/tsconfig-cjs.tsbuildinfo
npm notice 357.4kB tsconfig.tsbuildinfo          
npm notice === Tarball Details === 
npm notice name:          @woocommerce/explat                     
npm notice version:       1.1.0                                   
npm notice filename:      woocommerce-explat-1.1.0.tgz            
npm notice package size:  82.9 kB                                 
npm notice unpacked size: 768.6 kB                                
npm notice shasum:        8cbaeeba5e7ef84890ab8c83617ee20755baff84
npm notice integrity:     sha512-mwinMdUXvFseG[...]ZWXAdT05RMKAQ==
npm notice total files:   18                                      
npm notice 
woocommerce-explat-1.1.0.tgz

This causes failures for consumers of the package, such as:

error  Unable to resolve path to module '@woocommerce/explat'  import/no-unresolved

To Reproduce

Publish all packages with the commands:

git clone git@github.com:woocommerce/woocommerce-admin.git
npm i
git checkout package-lock.json
npm run publish-packages:prod

Actual behavior:

Packages are published without build-module folder.

Expected behavior

Expecting packages to be published with build-module folder.

Additional context

Is this related to the changes in PR #7286?

@adrianduffell adrianduffell added priority: critical The issue is critical—e.g. a fatal error, security problem affecting many customers. type: bug The issue is a confirmed bug. labels Aug 19, 2021
@louwie17
Copy link
Contributor

Related to microsoft/TypeScript#30602

@adrianduffell
Copy link
Contributor Author

Closing, this was fixed in PR #7531

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: critical The issue is critical—e.g. a fatal error, security problem affecting many customers. type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants