You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We display a maximal number of SidebarView.displayedSiteLimit sites on the sidebar. The sites on the sidebar contains (in priority order) the current site, other recently used sites, and the rest of the user's sites.
Actual behavior
The issue with current implementation is SidebarView.displayedSiteLimit is hard-coded as exactly the same as RecentSitesService.maxSiteCount.
The current site may not be displayed if we change SidebarView.displayedSiteLimit to be a smaller number.
Steps to reproduce the behavior
Change SidebarView.displayedSiteLimit to be a number smaller than RecentSitesService.maxSiteCount.
Make sure there are at least RecentSitesService.maxSiteCount sites in a WP.com account.
Create a site named "Zoo" (any name that comes last in alphabetical order) in the WP.com account.
Launch the Jetpack app and switch to a few different sites.
Select the "Zoo" site.
Open the sidebar, and check if "Zoo" is displayed in the sidebar.
That's a good point. I'd suggest changing RecentSitesService so that it doesn't artificially limited the number of most recent sites. It should be UI's job to determine how many to display.
Expected behavior
We display a maximal number of
SidebarView.displayedSiteLimit
sites on the sidebar. The sites on the sidebar contains (in priority order) the current site, other recently used sites, and the rest of the user's sites.Actual behavior
The issue with current implementation is
SidebarView.displayedSiteLimit
is hard-coded as exactly the same asRecentSitesService.maxSiteCount
.The current site may not be displayed if we change
SidebarView.displayedSiteLimit
to be a smaller number.Steps to reproduce the behavior
SidebarView.displayedSiteLimit
to be a number smaller thanRecentSitesService.maxSiteCount
.RecentSitesService.maxSiteCount
sites in a WP.com account.Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]
The text was updated successfully, but these errors were encountered: