Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading block Hx (level) buttons won't change icon color when active. #1398

Closed
etoledom opened this issue Oct 2, 2019 · 2 comments
Closed

Heading block Hx (level) buttons won't change icon color when active. #1398

etoledom opened this issue Oct 2, 2019 · 2 comments
Assignees
@marecar3
Labels
[Type] Bug Something isn't working
Milestone
1.14

Comments

@etoledom
Copy link
Contributor

etoledom commented Oct 2, 2019

Expected behavior

The icon color of Hx (level) toolbar buttons on Heading block should be white when the button is active.

Actual behavior

They stay the same color when inactive.

Hx

Steps to reproduce the behavior

  • Add a Heading block.
  • Check the Heading Level buttons on the toolbar.
@etoledom etoledom added the [Type] Bug Something isn't working label Oct 2, 2019
@etoledom etoledom mentioned this issue Oct 2, 2019
Merged
1 task
@marecar3
Copy link
Contributor

marecar3 commented Oct 2, 2019

It seems that we need to support the new heading icon on gb-mobile side: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/heading/heading-level-icon.js or to examine options on how to pass style to SVG.

@marecar3 marecar3 self-assigned this Oct 3, 2019
@marecar3 marecar3 added this to the 1.14 milestone Oct 3, 2019
@marecar3 marecar3 mentioned this issue Oct 3, 2019
Merged
5 tasks
@marecar3
Copy link
Contributor

marecar3 commented Oct 3, 2019

Fixed in: WordPress/gutenberg#17747

@marecar3 marecar3 closed this as completed Oct 3, 2019
@etoledom etoledom mentioned this issue Oct 4, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marecar3 marecar3

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
2 participants
@etoledom @marecar3