Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WP.com/Jetpack specific editor capability definitions from the Gutenberg repository #3911

Open
guarani opened this issue Sep 2, 2021 · 1 comment

Comments

@guarani
Copy link
Contributor

guarani commented Sep 2, 2021

We have WP.com and Jetpack references in https://github.com/wordpress/gutenberg which don't belong there.

These are the editor capability definitions for Jetpack Contact Info, Jetpack Story, Automattic Layout Grid, and soon Jetpack Tiled Gallery: iOS here, Android here.

I think a good solution could involve moving these definitions out of the Gutenberg repo and into this repo, where I think it's acceptable to have references to WP.com/Jetpack.
The demo projects for Gutenberg Mobile and Gutenberg share the same native code which lives in the Gutenberg repo. Since capabilities are defined in native code, I don't know of a straightforward way to remove these capability definitions from the Gutenberg repo. We could use this issue as a spike to scope out this problem before working on it.

@hypest
Copy link
Contributor

hypest commented Sep 3, 2021

+1, thanks for opening this ticket Paul!

I'll take a look on the Android side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants