fix: Prevent unnecessary content changes clearing redo actions #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems |
fluiddot
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Approved via WordPress/gutenberg#57028 (review) 🎊 .
Fix for undefined is not a function at getBlockInserterUsed
@dcalhoun Note that I added b91caf0 to fix another case of RichText value comparison. It can be tested with the following testing instructions:
- Build the app and connect it to a local Metro server. This is needed as the exception can't be seen in non-development builds.
- Create a post.
- Select the first Paragraph block.
- Press the enter key to create a new paragraph.
- Observe that no exception is thrown.
I already tested this case and confirmed that is no longer happening.
Test Android on Device - Full CI job failed in 4bc4ffe
Regarding #6462 (comment), since the E2E tests failing (see below list) seem unrelated to the writing flow, I'd say it's safe to merge.
- Test Suite 4 › Group block › should traverse up and down nested blocks
- Test Suite 4 › Group block › should navigate between nested blocks
…into version-toolkit/gutenberg/fix/prevent-unnecessary-content-changes-clearing-redo-actions
dcalhoun
deleted the
version-toolkit/gutenberg/fix/prevent-unnecessary-content-changes-clearing-redo-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.