Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max available memory that node can use in CI jobs #6503

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Increase max available memory that node can use in CI jobs #6503

merged 3 commits into from
Jan 4, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 4, 2024 •
edited
Loading

Fixes an issue in the CI job lint that we've recently encountered in PRs (325366d).

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

To test:

  • Check that all CI jobs pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

fluiddot
fluiddot commented Jan 4, 2024
View reviewed changes
.buildkite/pipeline.yml
@@ -7,6 +7,8 @@ x-common-params:
# Allow WP-CLI to be run as root, otherwise it throws an exception.
# Reference: https://git.io/J9q2S
- 'WP_CLI_ALLOW_ROOT=true'
# Increase max available memory for node
- 'NODE_OPTIONS="--max-old-space-size=4096"'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we could set this option directly in the Docker image.

@fluiddot fluiddot marked this pull request as ready for review January 4, 2024 17:15
@geriux geriux self-requested a review January 4, 2024 17:17
@geriux
Copy link
Member

geriux commented Jan 4, 2024

The XCFramework is failing because the Podfile.lock is missing an update from the release, which is included in this PR. Should we cherry-pick this PR into the Release PR? Or update the Podfile.lock here?

@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 4, 2024

The XCFramework is failing because the Podfile.lock is missing an update from the release, which is included in #6500. Should we cherry-pick this PR into the Release PR? Or update the Podfile.lock here?

Ah, true, I forgot to update the Podfile.lock. I'll update it, thanks 🙇 !

@fluiddot fluiddot mentioned this pull request Jan 4, 2024
Closed
2 tasks
@fluiddot fluiddot added this to the 1.111.0 (24.1) milestone Jan 4, 2024
geriux
geriux approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All CI checks passed ✅

@fluiddot fluiddot merged commit a1ba444 into trunk Jan 4, 2024
18 of 19 checks passed
@fluiddot fluiddot deleted the update/ci-increase-node-max-available-memory branch January 4, 2024 18:45
@fluiddot fluiddot mentioned this pull request Jan 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
Tooling
Projects
None yet
Milestone
1.111.0 (24.1)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @geriux