Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other search languages ( #57

Closed
hjm79 opened this issue Sep 24, 2022 · 7 comments
Closed

Support for other search languages ( #57

hjm79 opened this issue Sep 24, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@hjm79
Copy link

hjm79 commented Sep 24, 2022

Search is only available in English.

Search is not available in Korean

Is future support possible?

@wrjlewis
Copy link
Owner

Can you give me some steps so I can test this, can I just create a new page with Korean language in it and see the workflow not find it? I can then see about a solution. Thanks

@hjm79
Copy link
Author

hjm79 commented Sep 26, 2022

yes can't find it

find korean word "우분투"

debugger running.

[19:17:50.500] Notion Search[Script Filter] Queuing argument ''
[19:17:50.866] Notion Search[Script Filter] Script with argv '(null)' finished
[19:17:50.868] Notion Search[Script Filter] {"items": [{"type": "default", "title": "\uc54c\ud504\ub808\ub4dc", "arg": "notion://www.notion.so/4b591fceac03489dab22e1a678151548", "subtitle": " ", "autocomplete": "\uc54c\ud504\ub808\ub4dc"}, {"type": "default", "title": "Mac \uad00\ub828", "arg": "notion://www.notion.so/f01ad34cf8524ac387245309a082b885", "subtitle": " ", "autocomplete": "Mac \uad00\ub828"}, {"type": "default", "title": "\uc2a4\ud06c\ub7a9", "arg": "notion://www.notion.so/0cb6beadd69740bcb7d8598cd0338b03", "subtitle": " ", "icon": {"path": "emojiicons/270f.png"}, "autocomplete": "\uc2a4\ud06c\ub7a9"}, {"type": "default", "title": "\uc11c\ubc84\ud3ec\ub7fc - \uc6d0\uaca9\uc811\uc18d \uac8c\uc774\ud2b8\uc6e8\uc774 Apache Guacamole. \ub3c4\ucee4\ub85c \uc124\uce58\ud558\uae30.(Feat. SSH/VNC/RDP \ub4f1)", "arg": "notion://www.notion.so/b66e51b8ae0d4f50b37d7fee3ff64fb6", "subtitle": " ", "autocomplete": "\uc11c\ubc84\ud3ec\ub7fc - \uc6d0\uaca9\uc811\uc18d \uac8c\uc774\ud2b8\uc6e8\uc774 Apache Guacamole. \ub3c4\ucee4\ub85c \uc124\uce58\ud558\uae30.(Feat. SSH/VNC/RDP \ub4f1)"}, {"type": "default", "title": "\uc6f9 \uc11c\ubc84: Nginx | Varins library", "arg": "notion://www.notion.so/c19e6b25c92445b2a73bce6e1788e46a", "subtitle": " ", "autocomplete": "\uc6f9 \uc11c\ubc84: Nginx | Varins library"}, {"type": "default", "title": "alfredapp/updated-third-party-python2-workflows: Third-party Python 2 Workflows updated to work on macOS Monterey 12.3 and above", "arg": "notion://www.notion.so/d26be043b25243b3be15495722bee370", "subtitle": " ", "autocomplete": "alfredapp/updated-third-party-python2-workflows: Third-party Python 2 Workflows updated to work on macOS Monterey 12.3 and above"}, {"type": "default", "title": "\uc54c\ud504\ub808\ub4dc \uc6cc\ud06c\ud50c\ub85c\uc6b0 - \ubaac\ud130\ub808\uc774 12.3\uc5d0 \ud30c\uc774\uc36c2(Python2) \uc124\uce58\ud558\uae30", "arg": "notion://www.notion.so/9bd6450271734dc3934ac710aad1d3de", "subtitle": " ", "autocomplete": "\uc54c\ud504\ub808\ub4dc \uc6cc\ud06c\ud50c\ub85c\uc6b0 - \ubaac\ud130\ub808\uc774 12.3\uc5d0 \ud30c\uc774\uc36c2(Python2) \uc124\uce58\ud558\uae30"}, {"type": "default", "title": "posts table pro setting", "arg": "notion://www.notion.so/36d7d0dcfc6e4bc9a793d1447d9803fb", "subtitle": " ", "autocomplete": "posts table pro setting"}, {"type": "default", "title": "safari \ub300\uccb4\ud558\uae30", "arg": "notion://www.notion.so/e6336ac8dab84d79b2f2ea533a4faa2f", "subtitle": " ", "autocomplete": "safari \ub300\uccb4\ud558\uae30"}]}
[19:17:51.609] Notion Search[Script Filter] Queuing argument 'ㅇ'
[19:17:52.032] Notion Search[Script Filter] Queuing argument '우'
[19:17:52.042] Notion Search[Script Filter] Script with argv '(null)' finished
[19:17:52.044] Notion Search[Script Filter] {"items": [{"type": "default", "title": "\uac10\uc0ac\ud569\ub2c8\ub2e4. \u3147\u3137(PPT\ub9cc\ub4e4 \ub54c \uc720\uc6a9\ud55c \uc0ac\uc774\ud2b8 \ubaa8\uc74c)", "arg": "notion://www.notion.so/58937163ac0b40d987aab990b26f8500", "subtitle": " ", "autocomplete": "\uac10\uc0ac\ud569\ub2c8\ub2e4. \u3147\u3137(PPT\ub9cc\ub4e4 \ub54c \uc720\uc6a9\ud55c \uc0ac\uc774\ud2b8 \ubaa8\uc74c)"}, {"type": "default", "title": "\uac10\uc0ac\ud569\ub2c8\ub2e4. \u3147\u3137(PPT\ub9cc\ub4e4 \ub54c \uc720\uc6a9\ud55c \uc0ac\uc774\ud2b8 \ubaa8\uc74c)", "arg": "notion://www.notion.so/096c948367d74ab7b2fde7c4119ac682", "subtitle": " ", "autocomplete": "\uac10\uc0ac\ud569\ub2c8\ub2e4. \u3147\u3137(PPT\ub9cc\ub4e4 \ub54c \uc720\uc6a9\ud55c \uc0ac\uc774\ud2b8 \ubaa8\uc74c)"}, {"type": "default", "title": "\u3147\u3137\u3147\u3137", "arg": "notion://www.notion.so/fbcf3ba0621c46fd966f8db63a611b6e", "subtitle": " ", "autocomplete": "\u3147\u3137\u3147\u3137"}, {"type": "default", "title": "\u3147\u3137\u3147\u3137", "arg": "notion://www.notion.so/92ce4b2be8c746f4bc254621538b4205", "subtitle": " ", "autocomplete": "\u3147\u3137\u3147\u3137"}, {"type": "default", "title": "\u3147\u3137", "arg": "notion://www.notion.so/e0771278c8e6419ebb528d4742b49681", "subtitle": " ", "autocomplete": "\u3147\u3137"}, {"type": "default", "title": "\u3147\u3137", "arg": "notion://www.notion.so/3b3110a22fc14118a9bd9b91d82a309e", "subtitle": " ", "autocomplete": "\u3147\u3137"}, {"type": "default", "title": "\u3147\u3137", "arg": "notion://www.notion.so/a26863579cd84dc9badcc9549efe1b93", "subtitle": " ", "autocomplete": "\u3147\u3137"}, {"type": "default", "title": "\u3147\u3137", "arg": "notion://www.notion.so/dac9d9180afb4c8691ffe297895076d1", "subtitle": " ", "autocomplete": "\u3147\u3137"}, {"type": "default", "title": "\u3147\u3137", "arg": "notion://www.notion.so/bd002c833e9742c394fa0f91ffca76ba", "subtitle": " ", "autocomplete": "\u3147\u3137"}]}
[19:17:52.351] Notion Search[Script Filter] Queuing argument '웁'
[19:17:52.452] Notion Search[Script Filter] Script with argv '(null)' finished
[19:17:52.458] Notion Search[Script Filter] {"items": [{"uid": 1, "type": "default", "title": "Open Notion - No results, empty query, or error", "arg": "notion://www.notion.so/"}]}
[19:17:52.505] Notion Search[Script Filter] Queuing argument '우'
[19:17:52.511] Notion Search[Script Filter] Queuing argument '우부'
[19:17:52.612] Notion Search[Script Filter] Queuing argument '우분'
[19:17:52.761] Notion Search[Script Filter] Script with argv '(null)' finished
[19:17:52.767] Notion Search[Script Filter] {"items": [{"uid": 1, "type": "default", "title": "Open Notion - No results, empty query, or error", "arg": "notion://www.notion.so/"}]}
[19:17:52.913] Notion Search[Script Filter] Queuing argument '우분ㅌ'
[19:17:53.055] Notion Search[Script Filter] Queuing argument '우분투'
[19:17:53.130] Notion Search[Script Filter] Script with argv '(null)' finished
[19:17:53.135] Notion Search[Script Filter] {"items": [{"uid": 1, "type": "default", "title": "Open Notion - No results, empty query, or error", "arg": "notion://www.notion.so/"}]}
[19:17:53.457] Notion Search[Script Filter] Script with argv '(null)' finished
[19:17:53.465] Notion Search[Script Filter] {"items": [{"uid": 1, "type": "default", "title": "Open Notion - No results, empty query, or error", "arg": "notion://www.notion.so/"}]}

@hjm79 hjm79 closed this as completed Sep 26, 2022
@hjm79 hjm79 reopened this Sep 26, 2022
@wrjlewis
Copy link
Owner

Thank you, this is due to how unicode is being handled, will need someone who understands it properly to help, it should be a simple fix. Will mark this issue appropriately.

@wrjlewis wrjlewis added the help wanted Extra attention is needed label Sep 26, 2022
@hjm79
Copy link
Author

hjm79 commented Sep 26, 2022

#19 (comment)

Add

import unicodedata

alfredQuery = unicodedata.normalize('NFC',alfredQuery)

It works fine.

@wrjlewis wrjlewis self-assigned this Sep 27, 2022
@wrjlewis wrjlewis added bug Something isn't working and removed help wanted Extra attention is needed labels Sep 27, 2022
@wrjlewis wrjlewis mentioned this issue Sep 27, 2022
@wrjlewis
Copy link
Owner

Please try again with the new version released above and let me know if it works for you. Thanks @hjm79

@hjm79
Copy link
Author

hjm79 commented Sep 27, 2022

works great 👍
Thank you~~

@wrjlewis
Copy link
Owner

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants