Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagePullCredential reference not needed when using public docker images #190

Closed
Aaquiff opened this issue May 31, 2019 · 2 comments
Closed

imagePullCredential reference not needed when using public docker images #190

Aaquiff opened this issue May 31, 2019 · 2 comments
Assignees
@Aaquiff
Labels
Type/Bug

Comments

@Aaquiff
Copy link
Contributor

Aaquiff commented May 31, 2019 •
edited by chirangaalwis
Loading

Description:
The secret wso2creds is not created if username and password aren't given as values for the Helm charts. However the deployment manifest template contains reference (imagePullCredentials) to the above mentioned secret.
@Aaquiff
Copy link
Contributor Author

Aaquiff commented May 31, 2019

Fixed in PR #191

@chirangaalwis
Copy link
Member

Closing the issue as this is fixed in #191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaquiff Aaquiff

Labels
Type/Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chirangaalwis @Aaquiff