Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler silently falls back to older standards #137

Open
90degs2infty opened this issue Jun 20, 2023 · 0 comments
Open

Compiler silently falls back to older standards #137

90degs2infty opened this issue Jun 20, 2023 · 0 comments

Comments

@90degs2infty
Copy link

The CMakeLists.txt currently reads (line 9):

set(CMAKE_CXX_STANDARD 17)

When using an old compiler that does not support c++17, CMake will silently fall back to an older standard. This may lead to varying user-experience.

Consider setting CMAKE_CXX_STANDARD_REQUIRED as well as CMAKE_CXX_EXTENSIONS to ensure usage of c++17 (alongside a defined set of compiler extensions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant