Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GeoJSON rather than arbitrary JSON schema #38

Open
benbalter opened this issue Nov 28, 2013 · 5 comments
Open

Use GeoJSON rather than arbitrary JSON schema #38

benbalter opened this issue Nov 28, 2013 · 5 comments
Labels

Comments

@benbalter
Copy link

Cool idea. One suggestion: if you store the locations as GeoJSON rather than a purpose-built JSON schema you'll get a few advantages:

  1. GitHub will natively render the GeoJSON. Here's an example of bars in DC with WIFI. You could consume the GeoJSON directly into Leaflet (open source FTW) or even use the embed endpoint to embed the map directly, alleviating the need for complex client-side logic. (Raw GeoJSON)
  2. Rather than having to manually edit and geocode the JSON file, you could use something like geojson.io, so that people could edit the list directly in their browser
  3. It'd be an open format that could be natively consumed elsewhere.
@xando
Copy link
Owner

xando commented Dec 1, 2013

GeoJSON looks right. A bit to verbose for my needs but still looks like something that I should use it here.
I have quite a few merges to perform with old format then will replace it with GeoJSON.

Thanks for the suggestion

@jqb
Copy link
Collaborator

jqb commented Dec 28, 2013

Hi,

I've already added validateplaces.py to validate and merge data from different commiters. So generating differently formed json was a piece of cake: https://github.com/xando/commitcoffee/blob/gh-pages/places.geojson
I think it looks good :)

@jqb jqb closed this as completed Dec 28, 2013
@xando xando reopened this Dec 28, 2013
@xando
Copy link
Owner

xando commented Dec 28, 2013

I still would like to have GeoJSON rather than custom schema. Reopening this one.

@repat
Copy link
Contributor

repat commented Dec 15, 2014

is there any progress on this? should i rather submit my places in the geojson format?

update: just saw that it's done automatically.

@NotBobTheBuilder
Copy link
Collaborator

Yeah; on merge we generate both JSON and geojson 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants