Minimal conversion to pytest+hypothesis #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest defaults to running tests from files named `test_*`, so move the tests into one. Leave an empty `__init__.py` to keep relative imports working.
Use hypothesis as the closest pytest equivalent of nose_random. With some extra features like failure outputs with easy reproducers.
Closed
|
have you seen #51 ? How does it compare? |
|
Fixes #44. |
It roughly tries to minimize the amount of changes and make the code look as close to the original as possible. Also hypothesis is pretty neat when things start failing. |
|
thanks! |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to get the test suite working on pytest, without depending on nose in any way and while making minimal changes to the existing code.
What I had to do is:
__init__.pytotest_*.pynose_randomwithhypothesis…and that's pretty much it. It's fine to use unittest-style classes with pytest. Hypothesis seems to integrate neatly in place of
nose_random.