Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect Symbol.__eq__ by instance check. #82

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

J08nY
Copy link
Contributor

@J08nY J08nY commented Aug 26, 2024

This avoids an AttributeError when comparing to other objects.

This avoids an AttributeError when comparing to other objects.
@corytodd corytodd self-assigned this Aug 26, 2024
@corytodd corytodd added the bug label Aug 26, 2024
@corytodd
Copy link
Collaborator

Thanks for this. I meant to merge and publish today but ran out of time. Hopefully tomorrow!

@corytodd corytodd merged commit 6d5ce44 into xlwings:master Aug 29, 2024
8 checks passed
@corytodd
Copy link
Collaborator

Published as 2.2.1 -- thanks @J08nY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants