Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaLinkExtensions: Controls #671

Closed
LukeTOBrien opened this issue Oct 13, 2022 · 1 comment
Closed

MediaLinkExtensions: Controls #671

LukeTOBrien opened this issue Oct 13, 2022 · 1 comment

Comments

@LukeTOBrien
Copy link
Contributor

Hello,

I am creating a Static Website Generator and as one of my test I was creating a site with a video background, so this video has attributes muted, loop and autoplay but I do not want the controls attribute.
In MediaLinkExtension.cs line 113 there is code that adds the controls attribute but they is no way to say that I do not want this attribute to be added.
Do you think a boolean flag could be added to MediaOptions so that I can spefify that the attribute should not be added?

if (Options.Controls)
{
    htmlAttributes.AddPropertyIfNotExist("controls", null);
}

Thanks,

Luke

@xoofx
Copy link
Owner

xoofx commented Oct 13, 2022

Do you think a boolean flag could be added to MediaOptions so that I can spefify that the attribute should not be added?

Yeah, completely, PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants