fix(select): Issue #60 - Use suffixIcon instead of deprecated showArrow

BREAKING CHANGE: antd >= v5.8.0 required
xrutayisire · Oct 8, 2023 · dfef3b5 · dfef3b5
1 parent 1521675
commit dfef3b5
Show file tree

Hide file tree

Showing 5 changed files with 268 additions and 197 deletions.
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "enhanced-resolve": "5.10.0"
   },
   "peerDependencies": {
-    "antd": ">=5.5.0",
+    "antd": ">=5.8.0",
     "react": ">=17.0.0",
     "react-dom": ">=17.0.0"
   },
@@ -93,7 +93,7 @@
     "@types/react-dom": "18.0.9",
     "@typescript-eslint/eslint-plugin": "5.44.0",
     "@typescript-eslint/parser": "5.44.0",
-    "antd": "5.6.1",
+    "antd": "5.9.4",
     "babel-loader": "8.3.0",
     "cz-conventional-changelog": "3.3.0",
     "del-cli": "5.0.0",

diff --git a/src/components/CustomSelect.tsx b/src/components/CustomSelect.tsx
@@ -264,7 +264,7 @@ export default function CustomSelect(props: CustomSelectProps) {
       popupClassName={popupClassName}
       options={options}
       showSearch={false}
-      showArrow={!readOnly}
+      suffixIcon={readOnly ? null : undefined}
       menuItemSelectedIcon={null}
       popupMatchSelectWidth={false}
       onSelect={onOptionClick}

diff --git a/src/fields/Period.tsx b/src/fields/Period.tsx
@@ -129,7 +129,7 @@ export default function Period(props: PeriodProps) {
         className={selectClassName}
         popupClassName={popupClassName}
         disabled={disabled}
-        showArrow={!readOnly}
+        suffixIcon={readOnly ? null : undefined}
         open={readOnly ? false : undefined}
         data-testid='select-period'
         allowClear={allowClear}

diff --git a/src/types.ts b/src/types.ts
@@ -389,7 +389,7 @@ export interface CustomSelectProps
     | 'tagRender'
     | 'dropdownRender'
     | 'showSearch'
-    | 'showArrow'
+    | 'suffixIcon'
     | 'onChange'
     | 'dropdownMatchSelectWidth'
     | 'options'