Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make
bundle exec blade build
success with Ruby 3.3.0dev at 7-0-stable
This commit addresses the CI failure at 7-0-stable branch since ruby/ruby#7039 https://buildkite.com/rails/rails/builds/94361#0186a504-e06f-4f75-bcb6-df93822f78ed/3283-3286 - Without this commit ```ruby $ ruby -v ruby 3.3.0dev (2023-03-28T07:26:46Z master d766d5346b) [x86_64-linux] $ bundle exec blade build bundler: failed to load command: blade (/home/yahonda/.rbenv/versions/3.3.0-dev/bin/blade) /home/yahonda/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `initialize': wrong number of arguments (given 3, expected 1..2) (ArgumentError) PARAM2 = Regexp.new "(#{PATTERN::TOKEN})(?:=(#{PATTERN::VALUE2}))?(?:\\Z|;)", '', 'n' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ from /home/yahonda/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `new' ``` - With this commit ```ruby $ ruby -v ruby 3.3.0dev (2023-03-28T07:26:46Z master d766d5346b) [x86_64-linux] $ bundle exec blade build Building assets… $ ``` This commit has been made on top of `7-0-stable` not `main` branch because `blade` has been removed from main branch via rails#46206 `blade` gem depends on `cookiejar` indirectly as follows. `blade` depending on `faye` depending on `em-http-request` depending on `cookiejar` To use `cookiejar` with Ruby 3.3 it needs dwaite/cookiejar#52 merged. Instead of using `https://github.com/koic/cookiejar/tree/suppress_deprecation_warning_for_regexp_n_flag` branch cherry-pick the commit a73e526 because the this pull request may be changed like addressing RuboCop offenses. blade is only used for testing this change should be enough. Co-authored-by: Koichi ITO <koic.ito@gmail.com>
- Loading branch information