Suisin/chore: update content in passkey-config #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amina-deriv
reviewed
Apr 25, 2024
| ) : ( | ||
| (error as TServerError)?.message | ||
| ); | ||
| const button_text = | ||
| (error as TServerError)?.name === NOT_SUPPORTED_ERROR_NAME ? ( | ||
| <Localize i18n_default_text='Continue trading' /> | ||
| <Localize i18n_default_text='OK' /> | ||
| ) : ( | ||
| <Localize i18n_default_text='Try again' /> | ||
| ); |
There was a problem hiding this comment.
Do we need Try again button @suisin-deriv
There was a problem hiding this comment.
I think so, because there might be other errors
| @@ -157,6 +160,7 @@ export const getModalContent = ({ error, is_passkey_registration_started }: TGet | |||
| } | |||
|
|
|||
| return { | |||
| header: error_message_header, | |||
There was a problem hiding this comment.
header?
new requirement to design?
There was a problem hiding this comment.
the title of error is different according to requirements
amina-deriv
approved these changes
Apr 25, 2024
yauheni-deriv
merged commit fea44a9
into
yauheni-deriv:upm-923_add-not-supported-device-error
1 check failed
yauheni-deriv
added a commit
that referenced
this pull request
Apr 29, 2024
…ce (binary-com#14723) * chore: [UPM-923]/evgeniy/error message for passkey not supported device * fix: read of undefined * chore: added new button text and action for not supported * fix: error variable name * chore: update content in passkey-config (#42) * fix: content for unsupported error * Suisin/solve passkey header issue (#43) * chore: fix header not bold issue * chore: update passkey creation fail content * chore: refactor error content * chore: added comment to remove is_tour_open * chore: remove close icon for error modal * chore: remove close icon for error modal --------- Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com>
yauheni-deriv
pushed a commit
that referenced
this pull request
Aug 28, 2024
…binary-com#16135) * [WALL] george / WALL-4519 / Support XRP Deposits and Withdrawals in Wallets (#42) * refactor(wallets): ♻️ refactor wallets deposit/withdraw visibility * fix(wallets): 🚑 fix playwright tests * feat(wallets): ✨ add UI elements for XRP integration (#43) * feat(wallets): ✨ add UI elements for XRP integration * style: 💄 remove dark background * fix: 🚑 prevent crypto_config call for doughflow providers * fix: hardcode min withdrawal value for xrp * fix: withdrawalCryptoValidator min value * fix: withdrawalCryptoValidators min withdrawal value * fix: get min value from fractional digits --------- Co-authored-by: lubega-deriv <lubega@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Change passkey creation unsupported content to the latest updated content
Screenshots:
Please provide some screenshots of the change.