From b7116b1efb96f0cedd8afb6529b8186a9ccdaff2 Mon Sep 17 00:00:00 2001 From: Maxim Palenov Date: Mon, 9 Oct 2023 22:33:22 +0200 Subject: [PATCH] [Security Solution] Unskip misc rule management Serverless Cypress tests (#168305) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Addresses:** https://github.com/elastic/kibana/issues/161540 ## Summary This PR unskips miscelanious (not falling in one category but unskipping each one separately is overkill) rule management Serverless Cypress tests - `maintenance_window_callout.cy.ts` - `related_integrations.cy.ts` - `rule_delete.cy.ts` - `rule_snoozing.cy.ts` ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405 150 runs 🟢 --- .../maintenance_windows/maintenance_window_callout.cy.ts | 3 +-- .../related_integrations/related_integrations.cy.ts | 3 +-- .../rule_management/rule_actions/deletion/rule_delete.cy.ts | 2 +- .../rule_management/rule_actions/snoozing/rule_snoozing.cy.ts | 4 +--- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts index 7d8c0c18b7c301..c1929b15840d9d 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/maintenance_windows/maintenance_window_callout.cy.ts @@ -13,10 +13,9 @@ import { login } from '../../../../tasks/login'; import { visit } from '../../../../tasks/navigation'; import { RULES_MANAGEMENT_URL } from '../../../../urls/rules_management'; -// TODO: https://github.com/elastic/kibana/issues/161540 describe( 'Maintenance window callout on Rule Management page', - { tags: ['@ess', '@serverless', '@skipInServerless'] }, + { tags: ['@ess', '@serverless'] }, () => { let maintenanceWindowId = ''; diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/related_integrations/related_integrations.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/related_integrations/related_integrations.cy.ts index 4b375058247088..6f5434772e69a2 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/related_integrations/related_integrations.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/related_integrations/related_integrations.cy.ts @@ -45,8 +45,7 @@ import { waitForPageToBeLoaded, } from '../../../../tasks/rule_details'; -// TODO: https://github.com/elastic/kibana/issues/161540 -describe('Related integrations', { tags: ['@ess', '@serverless', '@brokenInServerless'] }, () => { +describe('Related integrations', { tags: ['@ess', '@serverless'] }, () => { const DATA_STREAM_NAME = 'logs-related-integrations-test'; const PREBUILT_RULE_NAME = 'Prebuilt rule with related integrations'; const RULE_RELATED_INTEGRATIONS: IntegrationDefinition[] = [ diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts index ae7ade60f1584c..563c8b85c1b733 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts @@ -20,7 +20,7 @@ import { createRule, findAllRules } from '../../../../../tasks/api_calls/rules'; import { deleteAlertsAndRules } from '../../../../../tasks/common'; import { login } from '../../../../../tasks/login'; -describe('Rule deletion', { tags: ['@ess', '@serverless', '@skipInServerless'] }, () => { +describe('Rule deletion', { tags: ['@ess', '@serverless'] }, () => { const testRules = [ getNewRule({ rule_id: 'rule1', name: 'Rule 1', enabled: false }), getNewRule({ rule_id: 'rule2', name: 'Rule 2', enabled: false }), diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/snoozing/rule_snoozing.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/snoozing/rule_snoozing.cy.ts index 2b1daa66013d7c..cbac9328fb4aaf 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/snoozing/rule_snoozing.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/snoozing/rule_snoozing.cy.ts @@ -43,9 +43,7 @@ import { TOOLTIP } from '../../../../../screens/common'; const RULES_TO_IMPORT_FILENAME = 'cypress/fixtures/7_16_rules.ndjson'; -// TODO: https://github.com/elastic/kibana/issues/161540 -// Flaky in serverless tests -describe('rule snoozing', { tags: ['@ess', '@serverless', '@skipInServerless'] }, () => { +describe('rule snoozing', { tags: ['@ess', '@serverless'] }, () => { before(() => { cleanKibana(); });