Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong env var used #224

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix wrong env var used #224

merged 1 commit into from
Aug 27, 2024

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Aug 27, 2024

There is no AYON_LOCAL_ID environment variable, only AYON_SITE_ID

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct. e.g. here.

There's no other mention of AYON_LOCAL_ID or AYON_SITE_ID in the docs. So this seems the only place to fix it.

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I agree with BigRoy.

@@ -200,7 +200,7 @@ As current implementation relies heavily on Settings and Site Settings, backgrou

To do this:

- run AYON `Tray` with environment variable AYON_LOCAL_ID set to name of active (source) site. In most use cases it would be studio (for cases of backups of everything published to studio site to different cloud site etc.)
- run AYON `Tray` with environment variable AYON_SITE_ID set to name of active (source) site. In most use cases it would be studio (for cases of backups of everything published to studio site to different cloud site etc.)
- start `Tray`
- check `Local ID` in information dialog after clicking on version number in the Tray
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: should this be site ID ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus points if we can add a screenshot showing the id in that dialog and maybe with arrows in the same image pointing to where to click in the tray menu, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bonus points @kalisp ? :)

@kalisp kalisp merged commit f87ed28 into main Aug 27, 2024
6 checks passed
@kalisp kalisp deleted the documentation/fix_site_id_var branch August 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants